From 02e67da266d21e106d0b9900a2a98dbf8d045ad2 Mon Sep 17 00:00:00 2001 From: Mason Reed Date: Thu, 28 May 2026 17:53:38 -0400 Subject: [Objective-C] Fix horrid bounds checking from previous fix Fixes 912465b5cf1d0442443d9584e15111361f27751c regression that broke cfstring parsing --- objectivec/objc.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/objectivec/objc.cpp b/objectivec/objc.cpp index 1b53a366..72f07c9c 100644 --- a/objectivec/objc.cpp +++ b/objectivec/objc.cpp @@ -1693,9 +1693,9 @@ void ObjCProcessor::ProcessCFStrings() { reader->Seek(i + ptrSize); uint64_t flags = reader->ReadPointer(); - auto strLoc = ReadPointerAccountingForRelocations(reader.get()); - auto size = reader->ReadPointer(); - if (size > cfstrings->GetEnd() || reader->GetOffset() > cfstrings->GetEnd() - size) + const auto strLoc = ReadPointerAccountingForRelocations(reader.get()); + const auto size = reader->ReadPointer(); + if (!m_data->IsValidOffset(strLoc + size)) { m_logger->LogWarn("CFString at 0x%llx has invalid size 0x%llx, skipping...", i, size); continue; -- cgit v1.3.1