From 2a97a8e0cce77c07df207248ca1ad3055e6733c6 Mon Sep 17 00:00:00 2001 From: Mark Rowe Date: Tue, 24 Feb 2026 16:20:36 -0800 Subject: Fix a crash that could occur in TypeDialog if parser results arrived at the wrong time --- ui/typedialog.h | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/ui/typedialog.h b/ui/typedialog.h index 67850e15..690b1650 100644 --- a/ui/typedialog.h +++ b/ui/typedialog.h @@ -85,18 +85,16 @@ class BINARYNINJAUIAPI TypeDialog : public QDialog QLabel* m_prompt; QString m_promptText; std::optional m_typeContainer; - bool m_resultValid; + bool m_resultValid = true; + bool m_resolved = false; QStringList m_historyEntries; int m_historySize; - GetTypesListThread* m_updateThread; - QFont m_defaultFont; - bool m_initialTextSelection; + GetTypesListThread* m_updateThread = nullptr; BinaryNinja::QualifiedNameAndType m_type; QPushButton* m_acceptButton; QTimer* m_updateTimer; QTimer* m_parseTimer; - bool m_isParsing; - std::atomic_bool m_comboBoxTextChanged; + bool m_isParsing = false; QPalette m_defaultPalette; QString m_parseError; -- cgit v1.3.1