From 5040858745478680624878361021717952745161 Mon Sep 17 00:00:00 2001 From: Glenn Smith Date: Thu, 4 Jun 2026 11:53:54 -0400 Subject: Move FindBinaryNinjaCore.cmake's error message to api It was never getting printed due to the stub generation code --- CMakeLists.txt | 2 +- cmake/FindBinaryNinjaCore.cmake | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index a8dd693b..9834463c 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -60,7 +60,7 @@ elseif(BN_ALLOW_STUBS) add_dependencies(binaryninjaapi binaryninjacore_stubs) target_link_libraries(binaryninjaapi PUBLIC binaryninjacore_stubs) else() - message(FATAL_ERROR "No Binary Ninja installation was found and stub generation is disabled") + message(FATAL_ERROR "Could NOT find Binary Ninja installation. Please configure with -DBN_INSTALL_DIR=, set the BN_INSTALL_DIR environment variable, or enable stub generation with -DBN_ALLOW_STUBS=ON") endif() if(BN_REF_COUNT_DEBUG) diff --git a/cmake/FindBinaryNinjaCore.cmake b/cmake/FindBinaryNinjaCore.cmake index bb34c335..cc436dea 100644 --- a/cmake/FindBinaryNinjaCore.cmake +++ b/cmake/FindBinaryNinjaCore.cmake @@ -42,8 +42,7 @@ if(NOT BN_INTERNAL_BUILD) include(FindPackageHandleStandardArgs) find_package_handle_standard_args(BinaryNinjaCore FOUND_VAR BinaryNinjaCore_FOUND - REQUIRED_VARS CORE_LIBRARY - FAIL_MESSAGE "Could NOT find Binary Ninja installation. Please configure with -DBN_INSTALL_DIR= or set the BN_INSTALL_DIR environment variable.") + REQUIRED_VARS CORE_LIBRARY) message(STATUS "Found Binary Ninja Core: ${CORE_LIBRARY}") -- cgit v1.3.1