From 8177643b10cad42b7eedab605e65fe7700a5ef8c Mon Sep 17 00:00:00 2001 From: Peter LaFosse Date: Wed, 13 Oct 2021 16:11:17 -0400 Subject: Remove func.create_auto_stack_var and only unit test stackAdjustment not its confidence --- suite/testcommon.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/suite/testcommon.py b/suite/testcommon.py index 0106f533..dcb7570b 100644 --- a/suite/testcommon.py +++ b/suite/testcommon.py @@ -330,13 +330,17 @@ class BinaryViewTestBuilder(Builder): for i, var in enumerate(func.stack_layout): funcinfo.append(f"Function: {func.start:x} Stack position {i}: {var}") - funcinfo.append(f"Function: {func.start:x} Stack adjustment: {func.stack_adjustment}") - funcinfo.append(f"Function: {func.start:x} Register stack adjustment: {func.reg_stack_adjustments}") + funcinfo.append(f"Function: {func.start:x} Stack adjustment: {func.stack_adjustment.value}") + funcinfo.append(f"Function: {func.start:x} Register stack adjustment: {[v.value for v in func.reg_stack_adjustments.values()]}") func.stack_adjustment = func.stack_adjustment func.reg_stack_adjustments = func.reg_stack_adjustments func.create_user_stack_var(0, binja.Type.int(4), "testuservar") - func.create_auto_stack_var(4, binja.Type.int(4), "testautovar") + # The following test has been commented as it leads to non-deterministic test results + # This is likely due to an extra update coming along afterward and removing sometimes + # This test would need to be conducted in an analysis pass to be consistent and accurate + # func.create_auto_stack_var(4, binja.Type.int(4), "testautovar") + funcinfo.append(f"Function: {func.start:x} Stack content sample: {func.get_stack_contents_at(func.start + 0x10, 0, 0x10)}") -- cgit v1.3.1