From 847c305528b2af050ccf8ef93a087d40b07bcd3a Mon Sep 17 00:00:00 2001 From: KyleMiles Date: Thu, 6 Oct 2022 16:55:31 -0400 Subject: Remove loading default load settings from BinaryData We might need that capability again in the future, but for now default load settings are only needed on non-raw views after this point in the API --- binaryninjaapi.h | 10 +++++----- binaryview.cpp | 20 +++++++++----------- 2 files changed, 14 insertions(+), 16 deletions(-) diff --git a/binaryninjaapi.h b/binaryninjaapi.h index 2eed35e0..15850e44 100644 --- a/binaryninjaapi.h +++ b/binaryninjaapi.h @@ -4407,11 +4407,11 @@ namespace BinaryNinja { class BinaryData : public BinaryView { public: - BinaryData(FileMetadata* file, bool setDefaultLoadSettings = false); - BinaryData(FileMetadata* file, const DataBuffer& data, bool setDefaultLoadSettings = false); - BinaryData(FileMetadata* file, const void* data, size_t len, bool setDefaultLoadSettings = false); - BinaryData(FileMetadata* file, const std::string& path, bool setDefaultLoadSettings = false); - BinaryData(FileMetadata* file, FileAccessor* accessor, bool setDefaultLoadSettings = false); + BinaryData(FileMetadata* file); + BinaryData(FileMetadata* file, const DataBuffer& data); + BinaryData(FileMetadata* file, const void* data, size_t len); + BinaryData(FileMetadata* file, const std::string& path); + BinaryData(FileMetadata* file, FileAccessor* accessor); }; class Platform; diff --git a/binaryview.cpp b/binaryview.cpp index 8b1fad53..713e2c0c 100644 --- a/binaryview.cpp +++ b/binaryview.cpp @@ -4199,28 +4199,26 @@ Ref Relocation::GetSymbol() const } -BinaryData::BinaryData(FileMetadata* file, bool setDefaultLoadSettings) : - BinaryView(BNCreateBinaryDataView(file->GetObject(), setDefaultLoadSettings)) -{} +BinaryData::BinaryData(FileMetadata* file) : BinaryView(BNCreateBinaryDataView(file->GetObject(), false)) {} -BinaryData::BinaryData(FileMetadata* file, const DataBuffer& data, bool setDefaultLoadSettings) : - BinaryView(BNCreateBinaryDataViewFromBuffer(file->GetObject(), data.GetBufferObject(), setDefaultLoadSettings)) +BinaryData::BinaryData(FileMetadata* file, const DataBuffer& data) : + BinaryView(BNCreateBinaryDataViewFromBuffer(file->GetObject(), data.GetBufferObject(), false)) {} -BinaryData::BinaryData(FileMetadata* file, const void* data, size_t len, bool setDefaultLoadSettings) : - BinaryView(BNCreateBinaryDataViewFromData(file->GetObject(), data, len, setDefaultLoadSettings)) +BinaryData::BinaryData(FileMetadata* file, const void* data, size_t len) : + BinaryView(BNCreateBinaryDataViewFromData(file->GetObject(), data, len, false)) {} -BinaryData::BinaryData(FileMetadata* file, const string& path, bool setDefaultLoadSettings) : - BinaryView(BNCreateBinaryDataViewFromFilename(file->GetObject(), path.c_str(), setDefaultLoadSettings)) +BinaryData::BinaryData(FileMetadata* file, const string& path) : + BinaryView(BNCreateBinaryDataViewFromFilename(file->GetObject(), path.c_str(), false)) {} -BinaryData::BinaryData(FileMetadata* file, FileAccessor* accessor, bool setDefaultLoadSettings) : - BinaryView(BNCreateBinaryDataViewFromFile(file->GetObject(), accessor->GetCallbacks(), setDefaultLoadSettings)) +BinaryData::BinaryData(FileMetadata* file, FileAccessor* accessor) : + BinaryView(BNCreateBinaryDataViewFromFile(file->GetObject(), accessor->GetCallbacks(), false)) {} -- cgit v1.3.1