From a086e7731c4761175f9280e952a9f500d6cdf997 Mon Sep 17 00:00:00 2001 From: Mark Rowe Date: Wed, 27 Aug 2025 12:59:36 -0700 Subject: Revert "Clarify the documentation on how multiple symbols at the same address are handled" This reverts commit 6293afcb4e10997838f94c38430feba9742bea75. --- binaryninjaapi.h | 11 ++--------- python/binaryview.py | 9 +++------ 2 files changed, 5 insertions(+), 15 deletions(-) diff --git a/binaryninjaapi.h b/binaryninjaapi.h index c7bd2d4c..589556f1 100644 --- a/binaryninjaapi.h +++ b/binaryninjaapi.h @@ -6689,8 +6689,7 @@ namespace BinaryNinja { /*! Adds a symbol to the internal list of automatically discovered Symbol objects in a given namespace - \warning If multiple symbols for the same address are defined, the most recently added symbol - with the highest confidence and lowest `BNSymbolType` value will be used. + \warning If multiple symbols for the same address are defined, only the most recent symbol will ever be used. \param sym Symbol to define */ @@ -6698,11 +6697,8 @@ namespace BinaryNinja { /*! Defines an "Auto" symbol, and a Variable/Function alongside it - \warning If multiple symbols for the same address are defined, the most recently added symbol - with the highest confidence and lowest `BNSymbolType` value will be used. - \param platform Platform for the Type being defined - \param sym Symbol being defined + \param sym Symbol being definedd \param type Type being defined \return The defined symbol */ @@ -6716,9 +6712,6 @@ namespace BinaryNinja { /*! Define a user symbol - \warning If multiple symbols for the same address are defined, the most recently added symbol - with the highest confidence and lowest `BNSymbolType` value will be used. - \param sym Symbol to define */ void DefineUserSymbol(Ref sym); diff --git a/python/binaryview.py b/python/binaryview.py index d516c054..e0c6cf10 100644 --- a/python/binaryview.py +++ b/python/binaryview.py @@ -6410,8 +6410,7 @@ class BinaryView: ``define_auto_symbol`` adds a symbol to the internal list of automatically discovered Symbol objects in a given namespace. - .. warning:: If multiple symbols for the same address are defined, only the most recently added symbol with the - highest confidence and lowest SymbolType value will ever be used. + .. warning:: If multiple symbols for the same address are defined, only the most recent symbol will ever be used. :param sym: the symbol to define :rtype: None @@ -6424,8 +6423,7 @@ class BinaryView: """ ``define_auto_symbol_and_var_or_function`` Defines an "Auto" symbol, and a Variable/Function alongside it. - .. warning:: If multiple symbols for the same address are defined, only the most recently added symbol with the - highest confidence and lowest SymbolType value will ever be used. + .. warning:: If multiple symbols for the same address are defined, only the most recent symbol will ever be used. :param sym: Symbol to define :param type: Type for the function/variable being defined (can be None) @@ -6467,8 +6465,7 @@ class BinaryView: """ ``define_user_symbol`` adds a symbol to the internal list of user added Symbol objects. - .. warning:: If multiple symbols for the same address are defined, only the most recently added symbol with the - highest confidence and lowest SymbolType value will ever be used. + .. warning:: If multiple symbols for the same address are defined, only the most recent symbol will ever be used. :param Symbol sym: the symbol to define :rtype: None -- cgit v1.3.1