From a54125565bb32bfb8af86f9b3ab3cb2151d76a14 Mon Sep 17 00:00:00 2001 From: Rusty Wagner Date: Wed, 30 Oct 2024 15:21:08 -0400 Subject: Fix memory ordering issues found with TSAN --- ui/featuremap.h | 2 +- ui/linearview.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/featuremap.h b/ui/featuremap.h index f17d5981..12b25488 100644 --- a/ui/featuremap.h +++ b/ui/featuremap.h @@ -47,7 +47,7 @@ class BINARYNINJAUIAPI FeatureMap : public QWidget, public BinaryNinja::BinaryDa BinaryViewRef m_data; std::unique_ptr m_dispatcher = nullptr; - bool m_updatesPending = false; + std::atomic m_updatesPending = false; QTimer* m_updateTimer = nullptr; size_t m_imgWidth = 0; size_t m_imgHeight = 0; diff --git a/ui/linearview.h b/ui/linearview.h index 05700e70..c3e2bce4 100644 --- a/ui/linearview.h +++ b/ui/linearview.h @@ -195,7 +195,7 @@ class BINARYNINJAUIAPI LinearView : public QAbstractScrollArea, public View, pub int m_wheelDelta; bool m_updatingScrollBar; - bool m_updatesRequired; + std::atomic m_updatesRequired; bool m_updateBounds; LinearViewCursorPosition m_cursorPos, m_selectionStartPos; -- cgit v1.3.1