From c1da063a1b6e627212414fe7896fd964b0e3532a Mon Sep 17 00:00:00 2001 From: Rusty Wagner Date: Tue, 10 Nov 2020 21:50:58 -0500 Subject: Fix warnings --- examples/llil_parser/src/llil_parser.cpp | 4 +-- examples/mlil_parser/src/mlil_parser.cpp | 4 +-- highlevelilinstruction.cpp | 32 +++++++++++----------- lowlevelilinstruction.cpp | 34 +++++++++++------------ mediumlevelilinstruction.cpp | 46 ++++++++++++++++---------------- 5 files changed, 60 insertions(+), 60 deletions(-) diff --git a/examples/llil_parser/src/llil_parser.cpp b/examples/llil_parser/src/llil_parser.cpp index 8df89558..b7c96c22 100644 --- a/examples/llil_parser/src/llil_parser.cpp +++ b/examples/llil_parser/src/llil_parser.cpp @@ -272,7 +272,7 @@ static void PrintILExpr(const LowLevelILInstruction& instr, size_t indent) case SSARegisterListLowLevelOperand: PrintIndent(indent); printf("ssa reg list "); - for (auto& i : operand.GetSSARegisterList()) + for (auto i : operand.GetSSARegisterList()) { PrintRegister(instr.function, i.reg); printf("#%" PRIdPTR " ", i.version); @@ -283,7 +283,7 @@ static void PrintILExpr(const LowLevelILInstruction& instr, size_t indent) case SSAFlagListLowLevelOperand: PrintIndent(indent); printf("ssa reg list "); - for (auto& i : operand.GetSSAFlagList()) + for (auto i : operand.GetSSAFlagList()) { PrintFlag(instr.function, i.flag); printf("#%" PRIdPTR " ", i.version); diff --git a/examples/mlil_parser/src/mlil_parser.cpp b/examples/mlil_parser/src/mlil_parser.cpp index 1a347dc3..e14c9317 100644 --- a/examples/mlil_parser/src/mlil_parser.cpp +++ b/examples/mlil_parser/src/mlil_parser.cpp @@ -213,7 +213,7 @@ static void PrintILExpr(const MediumLevelILInstruction& instr, size_t indent) case VariableListMediumLevelOperand: PrintIndent(indent); printf("var list "); - for (auto& i : operand.GetVariableList()) + for (auto i : operand.GetVariableList()) { PrintVariable(instr.function, i); printf(" "); @@ -224,7 +224,7 @@ static void PrintILExpr(const MediumLevelILInstruction& instr, size_t indent) case SSAVariableListMediumLevelOperand: PrintIndent(indent); printf("ssa var list "); - for (auto& i : operand.GetSSAVariableList()) + for (auto i : operand.GetSSAVariableList()) { PrintVariable(instr.function, i.var); printf("#%" PRIdPTR " ", i.version); diff --git a/highlevelilinstruction.cpp b/highlevelilinstruction.cpp index e4ad6c7b..2469f800 100644 --- a/highlevelilinstruction.cpp +++ b/highlevelilinstruction.cpp @@ -463,7 +463,7 @@ const HighLevelILInstruction HighLevelILInstructionList::operator[](size_t i) co HighLevelILInstructionList::operator vector() const { vector result; - for (auto& i : *this) + for (auto i : *this) result.push_back(i); return result; } @@ -521,7 +521,7 @@ const SSAVariable HighLevelILSSAVariableList::operator[](size_t i) const HighLevelILSSAVariableList::operator vector() const { vector result; - for (auto& i : *this) + for (auto i : *this) result.push_back(i); return result; } @@ -665,7 +665,7 @@ const HighLevelILOperand HighLevelILOperandList::operator[](size_t i) const HighLevelILOperandList::operator vector() const { vector result; - for (auto& i : *this) + for (auto i : *this) result.push_back(i); return result; } @@ -1237,7 +1237,7 @@ ExprId HighLevelILInstruction::CopyTo(HighLevelILFunction* dest, case HLIL_NOP: return dest->Nop(*this); case HLIL_BLOCK: - for (auto& i : GetBlockExprs()) + for (auto i : GetBlockExprs()) params.push_back(subExprHandler(i)); return dest->Block(params, *this); case HLIL_IF: @@ -1268,12 +1268,12 @@ ExprId HighLevelILInstruction::CopyTo(HighLevelILFunction* dest, subExprHandler(GetUpdateExpr()), subExprHandler(GetLoopExpr()), *this); case HLIL_SWITCH: - for (auto& i : GetCases()) + for (auto i : GetCases()) params.push_back(subExprHandler(i)); return dest->Switch(subExprHandler(GetConditionExpr()), subExprHandler(GetDefaultExpr()), params, *this); case HLIL_CASE: - for (auto& i : GetValueExprs()) + for (auto i : GetValueExprs()) params.push_back(subExprHandler(i)); return dest->Case(params, subExprHandler(GetTrueExpr()), *this); case HLIL_BREAK: @@ -1296,7 +1296,7 @@ ExprId HighLevelILInstruction::CopyTo(HighLevelILFunction* dest, return dest->Assign(size, subExprHandler(GetDestExpr()), subExprHandler(GetSourceExpr()), *this); case HLIL_ASSIGN_UNPACK: - for (auto& i : GetDestExprs()) + for (auto i : GetDestExprs()) output.push_back(subExprHandler(i)); return dest->AssignUnpack(output, subExprHandler(GetSourceExpr()), *this); @@ -1305,7 +1305,7 @@ ExprId HighLevelILInstruction::CopyTo(HighLevelILFunction* dest, GetDestMemoryVersion(), subExprHandler(GetSourceExpr()), GetSourceMemoryVersion(), *this); case HLIL_ASSIGN_UNPACK_MEM_SSA: - for (auto& i : GetDestExprs()) + for (auto i : GetDestExprs()) output.push_back(subExprHandler(i)); return dest->AssignUnpackMemSSA(output, GetDestMemoryVersion(), subExprHandler(GetSourceExpr()), @@ -1346,29 +1346,29 @@ ExprId HighLevelILInstruction::CopyTo(HighLevelILFunction* dest, case HLIL_ADDRESS_OF: return dest->AddressOf(subExprHandler(GetSourceExpr()), *this); case HLIL_CALL: - for (auto& i : GetParameterExprs()) + for (auto i : GetParameterExprs()) params.push_back(subExprHandler(i)); return dest->Call(subExprHandler(GetDestExpr()), params, *this); case HLIL_SYSCALL: - for (auto& i : GetParameterExprs()) + for (auto i : GetParameterExprs()) params.push_back(subExprHandler(i)); return dest->Syscall(params, *this); case HLIL_TAILCALL: - for (auto& i : GetParameterExprs()) + for (auto i : GetParameterExprs()) params.push_back(subExprHandler(i)); return dest->TailCall(subExprHandler(GetDestExpr()), params, *this); case HLIL_CALL_SSA: - for (auto& i : GetParameterExprs()) + for (auto i : GetParameterExprs()) params.push_back(subExprHandler(i)); return dest->CallSSA(subExprHandler(GetDestExpr()), params, GetDestMemoryVersion(), GetSourceMemoryVersion(), *this); case HLIL_SYSCALL_SSA: - for (auto& i : GetParameterExprs()) + for (auto i : GetParameterExprs()) params.push_back(subExprHandler(i)); return dest->SyscallSSA(params, GetDestMemoryVersion(), GetSourceMemoryVersion(), *this); case HLIL_RET: - for (auto& i : GetSourceExprs()) + for (auto i : GetSourceExprs()) params.push_back(subExprHandler(i)); return dest->Return(params, *this); case HLIL_NORET: @@ -1463,11 +1463,11 @@ ExprId HighLevelILInstruction::CopyTo(HighLevelILFunction* dest, case HLIL_TRAP: return dest->Trap(GetVector(), *this); case HLIL_INTRINSIC: - for (auto& i : GetParameterExprs()) + for (auto i : GetParameterExprs()) params.push_back(subExprHandler(i)); return dest->Intrinsic(GetIntrinsic(), params, *this); case HLIL_INTRINSIC_SSA: - for (auto& i : GetParameterExprs()) + for (auto i : GetParameterExprs()) params.push_back(subExprHandler(i)); return dest->IntrinsicSSA(GetIntrinsic(), params, GetDestMemoryVersion(), GetSourceMemoryVersion(), *this); diff --git a/lowlevelilinstruction.cpp b/lowlevelilinstruction.cpp index 529f6840..782f5943 100644 --- a/lowlevelilinstruction.cpp +++ b/lowlevelilinstruction.cpp @@ -795,7 +795,7 @@ size_t LowLevelILIndexMap::operator[](uint64_t value) const LowLevelILIndexMap::operator map() const { map result; - for (auto& i : *this) + for (auto i : *this) result[i.first] = i.second; return result; } @@ -907,7 +907,7 @@ const RegisterOrFlag LowLevelILRegisterOrFlagList::operator[](size_t i) const LowLevelILRegisterOrFlagList::operator vector() const { vector result; - for (auto& i : *this) + for (auto i : *this) result.push_back(i); return result; } @@ -965,7 +965,7 @@ const SSARegister LowLevelILSSARegisterList::operator[](size_t i) const LowLevelILSSARegisterList::operator vector() const { vector result; - for (auto& i : *this) + for (auto i : *this) result.push_back(i); return result; } @@ -1023,7 +1023,7 @@ const SSARegisterStack LowLevelILSSARegisterStackList::operator[](size_t i) cons LowLevelILSSARegisterStackList::operator vector() const { vector result; - for (auto& i : *this) + for (auto i : *this) result.push_back(i); return result; } @@ -1081,7 +1081,7 @@ const SSAFlag LowLevelILSSAFlagList::operator[](size_t i) const LowLevelILSSAFlagList::operator vector() const { vector result; - for (auto& i : *this) + for (auto i : *this) result.push_back(i); return result; } @@ -1139,7 +1139,7 @@ const SSARegisterOrFlag LowLevelILSSARegisterOrFlagList::operator[](size_t i) co LowLevelILSSARegisterOrFlagList::operator vector() const { vector result; - for (auto& i : *this) + for (auto i : *this) result.push_back(i); return result; } @@ -1400,7 +1400,7 @@ const LowLevelILOperand LowLevelILOperandList::operator[](size_t i) const LowLevelILOperandList::operator vector() const { vector result; - for (auto& i : *this) + for (auto i : *this) result.push_back(i); return result; } @@ -1898,16 +1898,16 @@ void LowLevelILInstruction::VisitExprs(const std::function().VisitExprs(func); - for (auto& i : GetParameterExprs()) + for (auto i : GetParameterExprs()) i.VisitExprs(func); break; case LLIL_SYSCALL_SSA: - for (auto& i : GetParameterExprs()) + for (auto i : GetParameterExprs()) i.VisitExprs(func); break; case LLIL_TAILCALL_SSA: GetDestExpr().VisitExprs(func); - for (auto& i : GetParameterExprs()) + for (auto i : GetParameterExprs()) i.VisitExprs(func); break; case LLIL_RET: @@ -1989,11 +1989,11 @@ void LowLevelILInstruction::VisitExprs(const std::function()) + for (auto i : GetParameterExprs()) i.VisitExprs(func); break; case LLIL_INTRINSIC_SSA: - for (auto& i : GetParameterExprs()) + for (auto i : GetParameterExprs()) i.VisitExprs(func); break; default: @@ -2166,19 +2166,19 @@ ExprId LowLevelILInstruction::CopyTo(LowLevelILFunction* dest, case LLIL_TRAP: return dest->Trap(GetVector(), *this); case LLIL_CALL_SSA: - for (auto& i : GetParameterExprs()) + for (auto i : GetParameterExprs()) params.push_back(subExprHandler(i)); return dest->CallSSA(GetOutputSSARegisters(), subExprHandler(GetDestExpr()), params, GetStackSSARegister(), GetDestMemoryVersion(), GetSourceMemoryVersion(), *this); case LLIL_SYSCALL_SSA: - for (auto& i : GetParameterExprs()) + for (auto i : GetParameterExprs()) params.push_back(subExprHandler(i)); return dest->SystemCallSSA(GetOutputSSARegisters(), params, GetStackSSARegister(), GetDestMemoryVersion(), GetSourceMemoryVersion(), *this); case LLIL_TAILCALL_SSA: - for (auto& i : GetParameterExprs()) + for (auto i : GetParameterExprs()) params.push_back(subExprHandler(i)); return dest->TailCallSSA(GetOutputSSARegisters(), subExprHandler(GetDestExpr()), params, GetStackSSARegister(), GetDestMemoryVersion(), @@ -2283,12 +2283,12 @@ ExprId LowLevelILInstruction::CopyTo(LowLevelILFunction* dest, subExprHandler(AsTwoOperandWithCarry().GetRightExpr()), subExprHandler(AsTwoOperandWithCarry().GetCarryExpr())); case LLIL_INTRINSIC: - for (auto& i : GetParameterExprs()) + for (auto i : GetParameterExprs()) params.push_back(subExprHandler(i)); return dest->Intrinsic(GetOutputRegisterOrFlagList(), GetIntrinsic(), params, flags, *this); case LLIL_INTRINSIC_SSA: - for (auto& i : GetParameterExprs()) + for (auto i : GetParameterExprs()) params.push_back(subExprHandler(i)); return dest->IntrinsicSSA(GetOutputSSARegisterOrFlagList(), GetIntrinsic(), params, *this); diff --git a/mediumlevelilinstruction.cpp b/mediumlevelilinstruction.cpp index b535ef5a..f389fb52 100644 --- a/mediumlevelilinstruction.cpp +++ b/mediumlevelilinstruction.cpp @@ -550,7 +550,7 @@ size_t MediumLevelILIndexMap::operator[](uint64_t value) const MediumLevelILIndexMap::operator map() const { map result; - for (auto& i : *this) + for (auto i : *this) result[i.first] = i.second; return result; } @@ -604,7 +604,7 @@ const Variable MediumLevelILVariableList::operator[](size_t i) const MediumLevelILVariableList::operator vector() const { vector result; - for (auto& i : *this) + for (auto i : *this) result.push_back(i); return result; } @@ -662,7 +662,7 @@ const SSAVariable MediumLevelILSSAVariableList::operator[](size_t i) const MediumLevelILSSAVariableList::operator vector() const { vector result; - for (auto& i : *this) + for (auto i : *this) result.push_back(i); return result; } @@ -720,7 +720,7 @@ const MediumLevelILInstruction MediumLevelILInstructionList::operator[](size_t i MediumLevelILInstructionList::operator vector() const { vector result; - for (auto& i : *this) + for (auto i : *this) result.push_back(i); return result; } @@ -891,7 +891,7 @@ const MediumLevelILOperand MediumLevelILOperandList::operator[](size_t i) const MediumLevelILOperandList::operator vector() const { vector result; - for (auto& i : *this) + for (auto i : *this) result.push_back(i); return result; } @@ -1333,7 +1333,7 @@ void MediumLevelILInstruction::VisitExprs(const std::function().VisitExprs(func); - for (auto& i : GetParameterExprs()) + for (auto i : GetParameterExprs()) i.VisitExprs(func); break; case MLIL_CALL_UNTYPED: @@ -1341,23 +1341,23 @@ void MediumLevelILInstruction::VisitExprs(const std::function().VisitExprs(func); - for (auto& i : GetParameterExprs()) + for (auto i : GetParameterExprs()) i.VisitExprs(func); break; case MLIL_CALL_UNTYPED_SSA: GetDestExpr().VisitExprs(func); break; case MLIL_SYSCALL: - for (auto& i : GetParameterExprs()) + for (auto i : GetParameterExprs()) i.VisitExprs(func); break; case MLIL_SYSCALL_SSA: - for (auto& i : GetParameterExprs()) + for (auto i : GetParameterExprs()) i.VisitExprs(func); break; case MLIL_TAILCALL: GetDestExpr().VisitExprs(func); - for (auto& i : GetParameterExprs()) + for (auto i : GetParameterExprs()) i.VisitExprs(func); break; case MLIL_TAILCALL_UNTYPED: @@ -1365,14 +1365,14 @@ void MediumLevelILInstruction::VisitExprs(const std::function().VisitExprs(func); - for (auto& i : GetParameterExprs()) + for (auto i : GetParameterExprs()) i.VisitExprs(func); break; case MLIL_TAILCALL_UNTYPED_SSA: GetDestExpr().VisitExprs(func); break; case MLIL_RET: - for (auto& i : GetSourceExprs()) + for (auto i : GetSourceExprs()) i.VisitExprs(func); break; case MLIL_STORE: @@ -1475,11 +1475,11 @@ void MediumLevelILInstruction::VisitExprs(const std::function()) + for (auto i : GetParameterExprs()) i.VisitExprs(func); break; case MLIL_INTRINSIC_SSA: - for (auto& i : GetParameterExprs()) + for (auto i : GetParameterExprs()) i.VisitExprs(func); break; default: @@ -1569,7 +1569,7 @@ ExprId MediumLevelILInstruction::CopyTo(MediumLevelILFunction* dest, return dest->AddressOfField(GetSourceVariable(), GetOffset(), *this); case MLIL_CALL: - for (auto& i : GetParameterExprs()) + for (auto i : GetParameterExprs()) params.push_back(subExprHandler(i)); return dest->Call(GetOutputVariables(), subExprHandler(GetDestExpr()), params, *this); @@ -1578,7 +1578,7 @@ ExprId MediumLevelILInstruction::CopyTo(MediumLevelILFunction* dest, subExprHandler(GetDestExpr()), GetParameterVariables(), subExprHandler(GetStackExpr()), *this); case MLIL_CALL_SSA: - for (auto& i : GetParameterExprs()) + for (auto i : GetParameterExprs()) params.push_back(subExprHandler(i)); return dest->CallSSA(GetOutputSSAVariables(), subExprHandler(GetDestExpr()), params, GetDestMemoryVersion(), GetSourceMemoryVersion(), *this); @@ -1590,7 +1590,7 @@ ExprId MediumLevelILInstruction::CopyTo(MediumLevelILFunction* dest, GetSourceMemoryVersion(), subExprHandler(GetStackExpr()), *this); case MLIL_SYSCALL: - for (auto& i : GetParameterExprs()) + for (auto i : GetParameterExprs()) params.push_back(subExprHandler(i)); return dest->Syscall(GetOutputVariables(), params, *this); case MLIL_SYSCALL_UNTYPED: @@ -1598,7 +1598,7 @@ ExprId MediumLevelILInstruction::CopyTo(MediumLevelILFunction* dest, GetParameterVariables(), subExprHandler(GetStackExpr()), *this); case MLIL_SYSCALL_SSA: - for (auto& i : GetParameterExprs()) + for (auto i : GetParameterExprs()) params.push_back(subExprHandler(i)); return dest->SyscallSSA(GetOutputSSAVariables(), params, GetDestMemoryVersion(), GetSourceMemoryVersion(), *this); @@ -1609,7 +1609,7 @@ ExprId MediumLevelILInstruction::CopyTo(MediumLevelILFunction* dest, GetSourceMemoryVersion(), subExprHandler(GetStackExpr()), *this); case MLIL_TAILCALL: - for (auto& i : GetParameterExprs()) + for (auto i : GetParameterExprs()) params.push_back(subExprHandler(i)); return dest->TailCall(GetOutputVariables(), subExprHandler(GetDestExpr()), params, *this); @@ -1618,7 +1618,7 @@ ExprId MediumLevelILInstruction::CopyTo(MediumLevelILFunction* dest, subExprHandler(GetDestExpr()), GetParameterVariables(), subExprHandler(GetStackExpr()), *this); case MLIL_TAILCALL_SSA: - for (auto& i : GetParameterExprs()) + for (auto i : GetParameterExprs()) params.push_back(subExprHandler(i)); return dest->TailCallSSA(GetOutputSSAVariables(), subExprHandler(GetDestExpr()), params, GetDestMemoryVersion(), GetSourceMemoryVersion(), *this); @@ -1630,7 +1630,7 @@ ExprId MediumLevelILInstruction::CopyTo(MediumLevelILFunction* dest, GetSourceMemoryVersion(), subExprHandler(GetStackExpr()), *this); case MLIL_RET: - for (auto& i : GetSourceExprs()) + for (auto i : GetSourceExprs()) params.push_back(subExprHandler(i)); return dest->Return(params, *this); case MLIL_NORET: @@ -1778,12 +1778,12 @@ ExprId MediumLevelILInstruction::CopyTo(MediumLevelILFunction* dest, case MLIL_TRAP: return dest->Trap(GetVector(), *this); case MLIL_INTRINSIC: - for (auto& i : GetParameterExprs()) + for (auto i : GetParameterExprs()) params.push_back(subExprHandler(i)); return dest->Intrinsic(GetOutputVariables(), GetIntrinsic(), params, *this); case MLIL_INTRINSIC_SSA: - for (auto& i : GetParameterExprs()) + for (auto i : GetParameterExprs()) params.push_back(subExprHandler(i)); return dest->IntrinsicSSA(GetOutputSSAVariables(), GetIntrinsic(), params, *this); -- cgit v1.3.1