From eb36a2b19746fdcb849cb14685bb56bd19134166 Mon Sep 17 00:00:00 2001 From: Mason Reed Date: Wed, 2 Jul 2025 23:30:07 -0400 Subject: Fix TagType objects being leaked when opening tags sidebar --- binaryninjacore.h | 2 +- binaryview.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/binaryninjacore.h b/binaryninjacore.h index b2f02949..114eb191 100644 --- a/binaryninjacore.h +++ b/binaryninjacore.h @@ -5532,7 +5532,7 @@ extern "C" BINARYNINJACOREAPI size_t BNGetAllTagReferencesOfTypeCount(BNBinaryView* view, BNTagType* tagType); BINARYNINJACOREAPI void BNGetAllTagReferenceTypeCounts( BNBinaryView* view, BNTagType*** tagTypes, size_t** counts, size_t* count); - BINARYNINJACOREAPI void BNFreeTagReferenceTypeCounts(BNTagType** tagTypes, size_t* counts); + BINARYNINJACOREAPI void BNFreeTagReferenceTypeCounts(BNTagType** tagTypes, size_t* counts, size_t count); BINARYNINJACOREAPI BNTagReference* BNGetFunctionAllTagReferences(BNFunction* func, size_t* count); BINARYNINJACOREAPI BNTagReference* BNGetFunctionTagReferencesOfType( diff --git a/binaryview.cpp b/binaryview.cpp index 4f6c9354..bad12407 100644 --- a/binaryview.cpp +++ b/binaryview.cpp @@ -3373,7 +3373,7 @@ std::map, size_t> BinaryView::GetAllTagReferenceTypeCounts() result[new TagType(BNNewTagTypeReference(types[i]))] = counts[i]; } - BNFreeTagReferenceTypeCounts(types, counts); + BNFreeTagReferenceTypeCounts(types, counts, count); return result; } -- cgit v1.3.1