From 2aa2a28a341a2290fe0328a46dbe8e3d7bb3ba4d Mon Sep 17 00:00:00 2001 From: Galen Williamson Date: Fri, 8 Aug 2025 14:30:49 -0400 Subject: Corrected python docstring for LowLevelILFunction.float_convert [thumb2] removed redundant format suffixes from disassembly of VFP instruction [thumb2] Corrected lifting of VCVT instruction --- arch/armv7/thumb2_disasm/disassembler.cpp | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) (limited to 'arch/armv7/thumb2_disasm/disassembler.cpp') diff --git a/arch/armv7/thumb2_disasm/disassembler.cpp b/arch/armv7/thumb2_disasm/disassembler.cpp index 8c7902b7..6910307f 100644 --- a/arch/armv7/thumb2_disasm/disassembler.cpp +++ b/arch/armv7/thumb2_disasm/disassembler.cpp @@ -317,15 +317,16 @@ std::string get_thumb_operation_name(struct decomp_result* result) contents += tlookup[tindex]; contents += slookup[sindex]; } - if (format->operationFlags & INSTR_FORMAT_FLAG_F16) { - contents += ".F16"; - } - if (format->operationFlags & INSTR_FORMAT_FLAG_F32) { - contents += ".F32"; - } - if (format->operationFlags & INSTR_FORMAT_FLAG_F64) { - contents += ".F64"; - } + // These are obviated by the type specifier being included in the instruction_format.operation field in spec.cpp + // if (format->operationFlags & INSTR_FORMAT_FLAG_F16) { + // contents += ".F16"; + // } + // if (format->operationFlags & INSTR_FORMAT_FLAG_F32) { + // contents += ".F32"; + // } + // if (format->operationFlags & INSTR_FORMAT_FLAG_F64) { + // contents += ".F64"; + // } if (format->operationFlags & INSTR_FORMAT_FLAG_WIDE) { contents += ".w"; -- cgit v1.3.1