From f860e52fe85837ba9e1a9df578b54ab12a983089 Mon Sep 17 00:00:00 2001 From: Peter LaFosse Date: Fri, 13 Mar 2026 16:30:02 -0400 Subject: Ensure rounding flag is properly emitted on some x86 floating point instructions --- arch/x86/il.cpp | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) (limited to 'arch/x86/il.cpp') diff --git a/arch/x86/il.cpp b/arch/x86/il.cpp index 2c1cbd83..692ee04e 100644 --- a/arch/x86/il.cpp +++ b/arch/x86/il.cpp @@ -4742,13 +4742,13 @@ bool GetLowLevelILForInstruction(Architecture* arch, const uint64_t addr, LowLev break; case XED_ICLASS_F2XM1: - il.AddInstruction(il.Intrinsic(vector { RegisterOrFlag::Register(XED_REG_ST0) }, + il.AddInstruction(il.Intrinsic(vector { RegisterOrFlag::Register(XED_REG_ST0), RegisterOrFlag::Flag(IL_FLAG_C1)}, INTRINSIC_F2XM1, vector { il.Register(10, XED_REG_ST0) }, IL_FLAGWRITE_X87RND)); break; case XED_ICLASS_FBLD: il.AddInstruction(il.SetRegister(2, REG_X87_TOP, il.Sub(2, il.Register(2, REG_X87_TOP), il.Const(2, 1)))); - il.AddInstruction(il.Intrinsic(vector { RegisterOrFlag::Register(XED_REG_ST0) }, + il.AddInstruction(il.Intrinsic(vector { RegisterOrFlag::Register(XED_REG_ST0), RegisterOrFlag::Flag(IL_FLAG_C1) }, INTRINSIC_FBLD, vector { ReadILOperand(il, xedd, addr, 1, 1) }, IL_FLAGWRITE_X87C1Z)); break; @@ -4764,25 +4764,25 @@ bool GetLowLevelILForInstruction(Architecture* arch, const uint64_t addr, LowLev case XED_ICLASS_FSIN: il.AddInstruction(il.Intrinsic(vector { RegisterOrFlag::Register(XED_REG_ST0), - RegisterOrFlag::Flag(IL_FLAG_C2) }, INTRINSIC_FSIN, vector { il.Register(10, XED_REG_ST0) }, + RegisterOrFlag::Flag(IL_FLAG_C1), RegisterOrFlag::Flag(IL_FLAG_C2) }, INTRINSIC_FSIN, vector { il.Register(10, XED_REG_ST0) }, IL_FLAGWRITE_X87RND)); break; case XED_ICLASS_FCOS: il.AddInstruction(il.Intrinsic(vector { RegisterOrFlag::Register(XED_REG_ST0), - RegisterOrFlag::Flag(IL_FLAG_C2) }, INTRINSIC_FCOS, vector { il.Register(10, XED_REG_ST0) }, + RegisterOrFlag::Flag(IL_FLAG_C1), RegisterOrFlag::Flag(IL_FLAG_C2) }, INTRINSIC_FCOS, vector { il.Register(10, XED_REG_ST0) }, IL_FLAGWRITE_X87RND)); break; case XED_ICLASS_FSINCOS: il.AddInstruction(il.SetRegister(2, REG_X87_TOP, il.Sub(2, il.Register(2, REG_X87_TOP), il.Const(2, 1)))); il.AddInstruction(il.Intrinsic(vector { RegisterOrFlag::Register(XED_REG_ST1), - RegisterOrFlag::Register(XED_REG_ST0), RegisterOrFlag::Flag(IL_FLAG_C2) }, INTRINSIC_FSINCOS, + RegisterOrFlag::Register(XED_REG_ST0), RegisterOrFlag::Flag(IL_FLAG_C1), RegisterOrFlag::Flag(IL_FLAG_C2) }, INTRINSIC_FSINCOS, vector { il.Register(10, XED_REG_ST1) }, IL_FLAGWRITE_X87RND)); break; case XED_ICLASS_FPATAN: - il.AddInstruction(il.Intrinsic(vector { RegisterOrFlag::Register(XED_REG_ST1) }, + il.AddInstruction(il.Intrinsic(vector { RegisterOrFlag::Register(XED_REG_ST1), RegisterOrFlag::Flag(IL_FLAG_C1) }, INTRINSIC_FPATAN, vector { il.Register(10, XED_REG_ST0), il.Register(10, XED_REG_ST1) }, IL_FLAGWRITE_X87RND)); il.AddInstruction(il.RegisterStackFreeReg(XED_REG_ST0)); il.AddInstruction(il.SetRegister(2, REG_X87_TOP, il.Add(2, il.Register(2, REG_X87_TOP), il.Const(2, 1)))); @@ -4822,7 +4822,7 @@ bool GetLowLevelILForInstruction(Architecture* arch, const uint64_t addr, LowLev case XED_ICLASS_FPTAN: il.AddInstruction(il.Intrinsic(vector { RegisterOrFlag::Register(XED_REG_ST0), - RegisterOrFlag::Flag(IL_FLAG_C2) }, INTRINSIC_FPTAN, vector { il.Register(10, XED_REG_ST0) }, + RegisterOrFlag::Flag(IL_FLAG_C1), RegisterOrFlag::Flag(IL_FLAG_C2) }, INTRINSIC_FPTAN, vector { il.Register(10, XED_REG_ST0) }, IL_FLAGWRITE_X87RND)); il.AddInstruction(il.If(il.Flag(IL_FLAG_C2), doneLabel, falseLabel)); il.MarkLabel(falseLabel); @@ -4836,7 +4836,7 @@ bool GetLowLevelILForInstruction(Architecture* arch, const uint64_t addr, LowLev break; case XED_ICLASS_FSCALE: - il.AddInstruction(il.Intrinsic(vector { RegisterOrFlag::Register(XED_REG_ST0) }, + il.AddInstruction(il.Intrinsic(vector { RegisterOrFlag::Register(XED_REG_ST0), RegisterOrFlag::Flag(IL_FLAG_C1) }, INTRINSIC_FSCALE, vector { il.Register(10, XED_REG_ST0), il.Register(10, XED_REG_ST1) }, IL_FLAGWRITE_X87RND)); break; @@ -4855,7 +4855,7 @@ bool GetLowLevelILForInstruction(Architecture* arch, const uint64_t addr, LowLev break; case XED_ICLASS_FYL2X: - il.AddInstruction(il.Intrinsic(vector { RegisterOrFlag::Register(XED_REG_ST1) }, + il.AddInstruction(il.Intrinsic(vector { RegisterOrFlag::Register(XED_REG_ST1), RegisterOrFlag::Flag(IL_FLAG_C1)}, INTRINSIC_FYL2X, vector { il.Register(10, XED_REG_ST0), il.Register(10, XED_REG_ST1) }, IL_FLAGWRITE_X87RND)); il.AddInstruction(il.RegisterStackFreeReg(XED_REG_ST0)); @@ -4863,7 +4863,7 @@ bool GetLowLevelILForInstruction(Architecture* arch, const uint64_t addr, LowLev break; case XED_ICLASS_FYL2XP1: - il.AddInstruction(il.Intrinsic(vector { RegisterOrFlag::Register(XED_REG_ST1) }, + il.AddInstruction(il.Intrinsic(vector { RegisterOrFlag::Register(XED_REG_ST1), RegisterOrFlag::Flag(IL_FLAG_C1)}, INTRINSIC_FYL2XP1, vector { il.Register(10, XED_REG_ST0), il.Register(10, XED_REG_ST1) }, IL_FLAGWRITE_X87RND)); il.AddInstruction(il.RegisterStackFreeReg(XED_REG_ST0)); -- cgit v1.3.1