From 3607e3a8a94c1f1e16caa099bd81eaba6e182cb7 Mon Sep 17 00:00:00 2001
From: Josh Ferrell <josh@vector35.com>
Date: Tue, 13 Feb 2024 13:10:11 -0500
Subject: Rename ExternalLocation APIs to be more clear, add ExternalLocation
 and ExternalLibrary API documentation

---
 binaryninjaapi.h | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

(limited to 'binaryninjaapi.h')

diff --git a/binaryninjaapi.h b/binaryninjaapi.h
index d412464d..55fd672c 100644
--- a/binaryninjaapi.h
+++ b/binaryninjaapi.h
@@ -2417,16 +2417,16 @@ namespace BinaryNinja {
 	public:
 		ExternalLocation(BNExternalLocation* loc);
 
-		Ref<Symbol> GetInternalSymbol();
-		std::optional<uint64_t> GetAddress();
-		std::optional<std::string> GetSymbol();
+		Ref<Symbol> GetSourceSymbol();
+		std::optional<uint64_t> GetTargetAddress();
+		std::optional<std::string> GetTargetSymbol();
 		Ref<ExternalLibrary> GetExternalLibrary();
 
-		bool HasAddress();
-		bool HasSymbol();
+		bool HasTargetAddress();
+		bool HasTargetSymbol();
 
-		void SetAddress(std::optional<uint64_t> address);
-		void SetSymbol(std::optional<std::string> symbol);
+		bool SetTargetAddress(std::optional<uint64_t> address);
+		bool SetTargetSymbol(std::optional<std::string> symbol);
 		void SetExternalLibrary(Ref<ExternalLibrary> library);
 	};
 
@@ -6510,9 +6510,9 @@ namespace BinaryNinja {
 		Ref<ExternalLibrary> GetExternalLibrary(const std::string& name);
 		std::vector<Ref<ExternalLibrary>> GetExternalLibraries();
 
-		Ref<ExternalLocation> AddExternalLocation(Ref<Symbol> internalSymbol, Ref<ExternalLibrary> library, std::optional<std::string> externalSymbol, std::optional<uint64_t> externalAddress, bool isAuto = false);
-		void RemoveExternalLocation(Ref<Symbol> internalSymbol);
-		Ref<ExternalLocation> GetExternalLocation(Ref<Symbol> internalSymbol);
+		Ref<ExternalLocation> AddExternalLocation(Ref<Symbol> sourceSymbol, Ref<ExternalLibrary> library, std::optional<std::string> targetSymbol, std::optional<uint64_t> targetAddress, bool isAuto = false);
+		void RemoveExternalLocation(Ref<Symbol> sourceSymbol);
+		Ref<ExternalLocation> GetExternalLocation(Ref<Symbol> sourceSymbol);
 		std::vector<Ref<ExternalLocation>> GetExternalLocations();
 	};
 
-- 
cgit v1.3.1