From 02023064fc5e112985035a9c0b3dc0957cdfda02 Mon Sep 17 00:00:00 2001
From: Brian Potchik <brian@vector35.com>
Date: Sun, 11 Aug 2019 23:04:17 -0400
Subject: Eliminate mandatory ephemeral view creation during open with options.

---
 binaryview.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'binaryview.cpp')

diff --git a/binaryview.cpp b/binaryview.cpp
index e44bca2b..853d42d3 100644
--- a/binaryview.cpp
+++ b/binaryview.cpp
@@ -2994,7 +2994,7 @@ uint64_t BinaryView::GetUIntMetadata(const string& key)
 }
 
 
-Ref<Settings> BinaryView::GetLoadSettings(string typeName)
+Ref<Settings> BinaryView::GetLoadSettings(const string& typeName)
 {
 	BNSettings* settings = BNBinaryViewGetLoadSettings(m_object, typeName.c_str());
 	if (!settings)
@@ -3003,7 +3003,7 @@ Ref<Settings> BinaryView::GetLoadSettings(string typeName)
 }
 
 
-void BinaryView::SetLoadSettings(string typeName, Ref<Settings> settings)
+void BinaryView::SetLoadSettings(const string& typeName, Ref<Settings> settings)
 {
 	BNBinaryViewSetLoadSettings(m_object, typeName.c_str(), settings->GetObject());
 }
-- 
cgit v1.3.1