From 1d21f2de35633113c38692a4fcb7e0481c96fd08 Mon Sep 17 00:00:00 2001 From: KyleMiles Date: Fri, 7 Oct 2022 15:55:43 -0400 Subject: Remove default load settings; Move settings `analysis.debugInfoInternal` and `loader.debugInfoExternal` to `analysis.debugInfo.internal` and `analysis.debugInfo.external` --- binaryview.cpp | 20 +++++--------------- 1 file changed, 5 insertions(+), 15 deletions(-) (limited to 'binaryview.cpp') diff --git a/binaryview.cpp b/binaryview.cpp index 713e2c0c..bed725f1 100644 --- a/binaryview.cpp +++ b/binaryview.cpp @@ -4042,16 +4042,6 @@ void BinaryView::SetLoadSettings(const string& typeName, Ref settings) } -Ref BinaryView::GetDefaultLoadSettings(const string& typeName, Ref settings) -{ - BNSettings* defaultSettings = - BNBinaryViewGetDefaultLoadSettings(m_object, typeName.c_str(), settings ? settings->GetObject() : nullptr); - if (!defaultSettings) - return nullptr; - return new Settings(defaultSettings); -} - - BNAnalysisParameters BinaryView::GetParametersForAnalysis() { return BNGetParametersForAnalysis(m_object); @@ -4199,26 +4189,26 @@ Ref Relocation::GetSymbol() const } -BinaryData::BinaryData(FileMetadata* file) : BinaryView(BNCreateBinaryDataView(file->GetObject(), false)) {} +BinaryData::BinaryData(FileMetadata* file) : BinaryView(BNCreateBinaryDataView(file->GetObject())) {} BinaryData::BinaryData(FileMetadata* file, const DataBuffer& data) : - BinaryView(BNCreateBinaryDataViewFromBuffer(file->GetObject(), data.GetBufferObject(), false)) + BinaryView(BNCreateBinaryDataViewFromBuffer(file->GetObject(), data.GetBufferObject())) {} BinaryData::BinaryData(FileMetadata* file, const void* data, size_t len) : - BinaryView(BNCreateBinaryDataViewFromData(file->GetObject(), data, len, false)) + BinaryView(BNCreateBinaryDataViewFromData(file->GetObject(), data, len)) {} BinaryData::BinaryData(FileMetadata* file, const string& path) : - BinaryView(BNCreateBinaryDataViewFromFilename(file->GetObject(), path.c_str(), false)) + BinaryView(BNCreateBinaryDataViewFromFilename(file->GetObject(), path.c_str())) {} BinaryData::BinaryData(FileMetadata* file, FileAccessor* accessor) : - BinaryView(BNCreateBinaryDataViewFromFile(file->GetObject(), accessor->GetCallbacks(), false)) + BinaryView(BNCreateBinaryDataViewFromFile(file->GetObject(), accessor->GetCallbacks())) {} -- cgit v1.3.1