From 224e24b283b8be99415431856e6b63dea7305996 Mon Sep 17 00:00:00 2001 From: Brian Potchik Date: Mon, 19 Apr 2021 15:39:33 -0400 Subject: Fix Mach-O duplicate symbol handling for external relocations. --- binaryview.cpp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) (limited to 'binaryview.cpp') diff --git a/binaryview.cpp b/binaryview.cpp index a803bf2e..f791090b 100644 --- a/binaryview.cpp +++ b/binaryview.cpp @@ -2211,10 +2211,12 @@ void BinaryView::DefineAutoSymbol(Ref sym) } -void BinaryView::DefineAutoSymbolAndVariableOrFunction(Ref platform, Ref sym, Ref type) +Ref BinaryView::DefineAutoSymbolAndVariableOrFunction(Ref platform, Ref sym, Ref type) { - BNDefineAutoSymbolAndVariableOrFunction(m_object, platform ? platform->GetObject() : nullptr, sym->GetObject(), - type ? type->GetObject() : nullptr); + BNSymbol* result = BNDefineAutoSymbolAndVariableOrFunction(m_object, platform ? platform->GetObject() : nullptr, sym->GetObject(), type ? type->GetObject() : nullptr); + if (!result) + return nullptr; + return new Symbol(result); } -- cgit v1.3.1