From 6ed8f189b2a0607a13c2a2163d82993ca60d2a19 Mon Sep 17 00:00:00 2001
From: Rusty Wagner <rusty.wagner@gmail.com>
Date: Thu, 26 Jan 2023 16:37:39 -0500
Subject: Fix Type object leaks

---
 binaryview.cpp | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

(limited to 'binaryview.cpp')

diff --git a/binaryview.cpp b/binaryview.cpp
index 40e4144a..7232e647 100644
--- a/binaryview.cpp
+++ b/binaryview.cpp
@@ -1805,7 +1805,7 @@ bool BinaryView::GetDataVariableAtAddress(uint64_t addr, DataVariable& var)
 		return false;
 
 	var.address = result.address;
-	var.type = Confidence<Ref<Type>>(new Type(BNNewTypeReference(result.type)), result.typeConfidence);
+	var.type = Confidence<Ref<Type>>(new Type(result.type), result.typeConfidence);
 	var.autoDiscovered = result.autoDiscovered;
 	return true;
 }
@@ -3489,7 +3489,7 @@ Ref<Type> BinaryView::GetTypeByName(const QualifiedName& name)
 
 	if (!type)
 		return nullptr;
-	return new Type(BNNewTypeReference(type));
+	return new Type(type);
 }
 
 
@@ -3498,7 +3498,7 @@ Ref<Type> BinaryView::GetTypeByRef(Ref<NamedTypeReference> ref)
 	BNType* type = BNGetAnalysisTypeByRef(m_object, ref->m_object);
 	if (!type)
 		return nullptr;
-	return new Type(BNNewTypeReference(type));
+	return new Type(type);
 }
 
 
@@ -3507,7 +3507,7 @@ Ref<Type> BinaryView::GetTypeById(const string& id)
 	BNType* type = BNGetAnalysisTypeById(m_object, id.c_str());
 	if (!type)
 		return nullptr;
-	return new Type(BNNewTypeReference(type));
+	return new Type(type);
 }
 
 
@@ -4297,7 +4297,7 @@ Confidence<Ref<Type>> BinaryView::CreateStructureMemberFromAccess(const Qualifie
 	BNTypeWithConfidence type = BNCreateStructureMemberFromAccess(m_object, &typeObj, offset);
 
 	if (type.type)
-		return Confidence<Ref<Type>>(new Type(BNNewTypeReference(type.type)), type.confidence);
+		return Confidence<Ref<Type>>(new Type(type.type), type.confidence);
 	return nullptr;
 }
 
-- 
cgit v1.3.1