From c41f264a1dba68c89b4a224a70e3a5783f7fa879 Mon Sep 17 00:00:00 2001 From: Rusty Wagner Date: Tue, 24 Jun 2025 17:55:48 -0400 Subject: Remove implicit conversions from Confidence to underlying type, these can cause bugs and also issues with C++20 --- defaultabb.cpp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'defaultabb.cpp') diff --git a/defaultabb.cpp b/defaultabb.cpp index 477e5722..00d0e560 100644 --- a/defaultabb.cpp +++ b/defaultabb.cpp @@ -337,9 +337,9 @@ void Architecture::DefaultAnalyzeBasicBlocks(Function* function, BasicBlockAnaly { // Deal with direct pointers into the extern section DataVariable dataVar; - if (data->GetDataVariableAtAddress(info.branchTarget[i], dataVar) && - (dataVar.address == info.branchTarget[i]) && dataVar.type && - (dataVar.type->GetClass() == FunctionTypeClass)) + if (data->GetDataVariableAtAddress(info.branchTarget[i], dataVar) + && (dataVar.address == info.branchTarget[i]) && dataVar.type.GetValue() + && (dataVar.type->GetClass() == FunctionTypeClass)) { directRefs[info.branchTarget[i]].emplace(location); if (!dataVar.type->CanReturn()) @@ -414,9 +414,9 @@ void Architecture::DefaultAnalyzeBasicBlocks(Function* function, BasicBlockAnaly { // Deal with direct pointers into the extern section DataVariable dataVar; - if (data->GetDataVariableAtAddress(info.branchTarget[i], dataVar) && - (dataVar.address == info.branchTarget[i]) && dataVar.type && - (dataVar.type->GetClass() == FunctionTypeClass)) + if (data->GetDataVariableAtAddress(info.branchTarget[i], dataVar) + && (dataVar.address == info.branchTarget[i]) && dataVar.type.GetValue() + && (dataVar.type->GetClass() == FunctionTypeClass)) { directRefs[info.branchTarget[i]].emplace(location); if (!dataVar.type->CanReturn()) -- cgit v1.3.1