From 2aa2be5c713a76c86118a225c5cae6ef3585412d Mon Sep 17 00:00:00 2001 From: Brandon Miller Date: Wed, 17 Apr 2024 12:29:09 -0400 Subject: Simplified base address detection UI Moved advanced settings to expandable group and no longer display results items until analysis completes --- examples/triage/baseaddress.h | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) (limited to 'examples/triage/baseaddress.h') diff --git a/examples/triage/baseaddress.h b/examples/triage/baseaddress.h index 25701947..9a282f3e 100644 --- a/examples/triage/baseaddress.h +++ b/examples/triage/baseaddress.h @@ -8,6 +8,7 @@ #include #include "theme.h" #include "fontsettings.h" +#include "expandablegroup.h" #include "viewframe.h" #include "binaryninjaapi.h" #include "binaryninjacore.h" @@ -60,12 +61,11 @@ class BaseAddressDetectionWidget : public QWidget { BaseAddressDetectionThread* m_worker; BinaryNinja::Ref m_view; - QGridLayout* m_layout {}; + BaseAddressDetectionQtInputs m_inputs; + QGridLayout* m_layout {}; QPushButton* m_startButton = nullptr; QPushButton* m_abortButton = nullptr; - - BaseAddressDetectionQtInputs m_inputs; QLabel* m_preferredBaseLabel; QLabel* m_preferredBase; QLabel* m_confidenceLabel; @@ -74,12 +74,14 @@ class BaseAddressDetectionWidget : public QWidget QLineEdit* m_reloadBase; QPushButton* m_rebaseButton; QTableWidget* m_resultsTableWidget; + ExpandableGroup* m_advancedSettingsGroup; void DetectBaseAddress(); void RebaseWithFullAnalysis(); void Abort(); void HandleResults(const BaseAddressDetectionQtResults& results); void HideResultsWidgets(bool hide); + void CreateAdvancedSettingsGroup(); public: BaseAddressDetectionWidget(QWidget* parent, BinaryNinja::Ref bv); -- cgit v1.3.1