From 93bb3e8cf9ef789b5fdbf321815ed6108291786c Mon Sep 17 00:00:00 2001 From: Brian Potchik Date: Fri, 2 Aug 2019 22:05:36 -0400 Subject: Refactor settings system to be reference counted. --- examples/triage/view.cpp | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) (limited to 'examples/triage/view.cpp') diff --git a/examples/triage/view.cpp b/examples/triage/view.cpp index e4077521..ddd1d4ff 100644 --- a/examples/triage/view.cpp +++ b/examples/triage/view.cpp @@ -99,7 +99,7 @@ TriageView::TriageView(QWidget* parent, BinaryViewRef data): QScrollArea(parent) setWidgetResizable(true); setWidget(container); - if (m_fullAnalysisButton && (BinaryNinja::Settings().Get("analysis.mode", data) == "full")) + if (m_fullAnalysisButton && (BinaryNinja::Settings::Instance()->Get("analysis.mode", data) == "full")) m_fullAnalysisButton->hide(); } @@ -153,7 +153,7 @@ bool TriageView::navigate(uint64_t addr) void TriageView::startFullAnalysis() { - BinaryNinja::Settings().Set("analysis.mode", "full", m_data); + BinaryNinja::Settings::Instance()->Set("analysis.mode", "full", m_data); for (auto& f: m_data->GetAnalysisFunctionList()) { if (f->IsAnalysisSkipped()) @@ -220,9 +220,10 @@ TriageViewType::TriageViewType(): ViewType("Triage", "Triage Summary") int TriageViewType::getPriority(BinaryViewRef data, const QString&) { - bool full = BinaryNinja::Settings().Get("analysis.mode", data) == "full"; - bool alwaysPrefer = BinaryNinja::Settings().Get("triage.preferSummaryView", data); - bool preferForRaw = BinaryNinja::Settings().Get("triage.preferSummaryViewForRaw", data); + BinaryNinja::Ref settings = BinaryNinja::Settings::Instance(); + bool full = settings->Get("analysis.mode", data) == "full"; + bool alwaysPrefer = settings->Get("triage.preferSummaryView", data); + bool preferForRaw = settings->Get("triage.preferSummaryViewForRaw", data); if (data->IsExecutable() && (alwaysPrefer || !full)) return 100; if (data->GetLength() > 0) -- cgit v1.3.1