From fc28e5142593e69a960ab8dd72ff88a2f06065da Mon Sep 17 00:00:00 2001
From: Josh Ferrell <josh@vector35.com>
Date: Tue, 1 Oct 2024 14:14:10 -0400
Subject: Improve c++ http api performance

---
 http.cpp | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

(limited to 'http.cpp')

diff --git a/http.cpp b/http.cpp
index 084f4a85..12490a41 100644
--- a/http.cpp
+++ b/http.cpp
@@ -229,7 +229,7 @@ namespace BinaryNinja::Http
 	}
 
 
-	Request::Request(string method, string url, unordered_map<string, string> headers,
+	Request::Request(string method, string url, const unordered_map<string, string>& headers,
 	    vector<pair<string, string>> params, std::function<bool(size_t, size_t)> downloadProgress,
 	    std::function<bool(size_t, size_t)> uploadProgress) :
 	    m_method(method),
@@ -252,7 +252,7 @@ namespace BinaryNinja::Http
 	}
 
 
-	Request::Request(string method, string url, unordered_map<string, string> headers,
+	Request::Request(string method, string url, const unordered_map<string, string>& headers,
 	    vector<pair<string, string>> params, vector<uint8_t> body, std::function<bool(size_t, size_t)> downloadProgress,
 	    std::function<bool(size_t, size_t)> uploadProgress) :
 	    m_method(method),
@@ -276,7 +276,7 @@ namespace BinaryNinja::Http
 	}
 
 
-	Request::Request(string method, string url, unordered_map<string, string> headers,
+	Request::Request(string method, string url, const unordered_map<string, string>& headers,
 	    vector<pair<string, string>> params, vector<pair<string, string>> formFields,
 	    std::function<bool(size_t, size_t)> downloadProgress, std::function<bool(size_t, size_t)> uploadProgress) :
 	    m_method(method),
@@ -303,7 +303,7 @@ namespace BinaryNinja::Http
 	}
 
 
-	Request::Request(string method, string url, unordered_map<string, string> headers,
+	Request::Request(string method, string url, const unordered_map<string, string>& headers,
 	    vector<pair<string, string>> params, vector<MultipartField> formFields,
 	    std::function<bool(size_t, size_t)> downloadProgress, std::function<bool(size_t, size_t)> uploadProgress) :
 	    m_method(method),
@@ -331,31 +331,31 @@ namespace BinaryNinja::Http
 	}
 
 
-	Request Request::Get(string url, unordered_map<string, string> headers, vector<pair<string, string>> params,
+	Request Request::Get(string url, const unordered_map<string, string>& headers, const vector<pair<string, string>>& params,
 	    std::function<bool(size_t, size_t)> downloadProgress, std::function<bool(size_t, size_t)> uploadProgress)
 	{
 		return Request("GET", url, headers, params, downloadProgress, uploadProgress);
 	}
 
 
-	Request Request::Post(string url, unordered_map<string, string> headers, vector<pair<string, string>> params,
-	    vector<uint8_t> body, std::function<bool(size_t, size_t)> downloadProgress,
+	Request Request::Post(string url, const unordered_map<string, string>& headers, const vector<pair<string, string>>& params,
+	    const vector<uint8_t>& body, std::function<bool(size_t, size_t)> downloadProgress,
 	    std::function<bool(size_t, size_t)> uploadProgress)
 	{
 		return Request("POST", url, headers, params, body, downloadProgress, uploadProgress);
 	}
 
 
-	Request Request::Post(string url, unordered_map<string, string> headers, vector<pair<string, string>> params,
-	    vector<pair<string, string>> formFields, std::function<bool(size_t, size_t)> downloadProgress,
+	Request Request::Post(string url, const unordered_map<string, string>& headers, const vector<pair<string, string>>& params,
+	    const vector<pair<string, string>>& formFields, std::function<bool(size_t, size_t)> downloadProgress,
 	    std::function<bool(size_t, size_t)> uploadProgress)
 	{
 		return Request("POST", url, headers, params, formFields, downloadProgress, uploadProgress);
 	}
 
 
-	Request Request::Post(string url, unordered_map<string, string> headers, vector<pair<string, string>> params,
-	    vector<MultipartField> formFields, std::function<bool(size_t, size_t)> downloadProgress,
+	Request Request::Post(string url, const unordered_map<string, string>& headers, const vector<pair<string, string>>& params,
+	    const vector<MultipartField>& formFields, std::function<bool(size_t, size_t)> downloadProgress,
 	    std::function<bool(size_t, size_t)> uploadProgress)
 	{
 		return Request("POST", url, headers, params, formFields, downloadProgress, uploadProgress);
-- 
cgit v1.3.1