From 5ee61e3000c366970f170c0fb4428875ee01d49b Mon Sep 17 00:00:00 2001 From: Mark Rowe Date: Mon, 3 Nov 2025 16:14:16 -0800 Subject: [ObjC] Remove unnecesary BeginUndoActions / ForgetUndoActions The symbol creation code in `ObjCProcessor` was updated to avoid creating undo actions some time ago, but removing these calls was missed due to the timing of when the PR that introduced them was merged. --- objectivec/objc.cpp | 10 ---------- 1 file changed, 10 deletions(-) (limited to 'objectivec/objc.cpp') diff --git a/objectivec/objc.cpp b/objectivec/objc.cpp index a30a9ab6..d4476de4 100644 --- a/objectivec/objc.cpp +++ b/objectivec/objc.cpp @@ -1770,10 +1770,8 @@ void ObjCProcessor::ProcessNSConstantArrays() DefineObjCSymbol(DataSymbol, Type::NamedType(m_data, m_typeNames.nsConstantArray), fmt::format("nsarray_{:x}", i), i, true); } - auto id = m_data->BeginUndoActions(); ScopedSymbolQueue::Get().Process(); m_data->EndBulkModifySymbols(); - m_data->ForgetUndoActions(id); } } @@ -1813,10 +1811,8 @@ void ObjCProcessor::ProcessNSConstantDictionaries() DefineObjCSymbol(DataSymbol, Type::NamedType(m_data, m_typeNames.nsConstantDictionary), fmt::format("nsdict_{:x}", i), i, true); } - auto id = m_data->BeginUndoActions(); ScopedSymbolQueue::Get().Process(); m_data->EndBulkModifySymbols(); - m_data->ForgetUndoActions(id); } } @@ -1870,10 +1866,8 @@ void ObjCProcessor::ProcessNSConstantIntegerNumbers() continue; } } - auto id = m_data->BeginUndoActions(); ScopedSymbolQueue::Get().Process(); m_data->EndBulkModifySymbols(); - m_data->ForgetUndoActions(id); } } @@ -1960,10 +1954,8 @@ void ObjCProcessor::ProcessNSConstantFloatingPointNumbers() } DefineObjCSymbol(DataSymbol, Type::NamedType(m_data, *typeName), name, i, true); } - auto id = m_data->BeginUndoActions(); ScopedSymbolQueue::Get().Process(); m_data->EndBulkModifySymbols(); - m_data->ForgetUndoActions(id); } } @@ -1996,10 +1988,8 @@ void ObjCProcessor::ProcessNSConstantDatas() DefineObjCSymbol( DataSymbol, Type::NamedType(m_data, m_typeNames.nsConstantData), fmt::format("nsdata_{:x}", i), i, true); } - auto id = m_data->BeginUndoActions(); ScopedSymbolQueue::Get().Process(); m_data->EndBulkModifySymbols(); - m_data->ForgetUndoActions(id); } } -- cgit v1.3.1