From c41f264a1dba68c89b4a224a70e3a5783f7fa879 Mon Sep 17 00:00:00 2001 From: Rusty Wagner Date: Tue, 24 Jun 2025 17:55:48 -0400 Subject: Remove implicit conversions from Confidence to underlying type, these can cause bugs and also issues with C++20 --- objectivec/objc.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'objectivec/objc.cpp') diff --git a/objectivec/objc.cpp b/objectivec/objc.cpp index da531e80..a34cffe1 100644 --- a/objectivec/objc.cpp +++ b/objectivec/objc.cpp @@ -343,7 +343,7 @@ void ObjCProcessor::DefineObjCSymbol( new Symbol(type, shortName, fullName, name, addr, LocalBinding, nameSpace), typeRef); }; - auto defineSymbol = [this](Ref symbol, Ref type) { + auto defineSymbol = [this](Ref symbol, const Confidence>& type) { uint64_t symbolAddress = symbol->GetAddress(); // Armv7/Thumb: This will rewrite the symbol's address. // e.g. We pass in 0xc001, it will rewrite it to 0xc000 and create the function w/ the "thumb2" arch. @@ -354,8 +354,8 @@ void ObjCProcessor::DefineObjCSymbol( { // For thumb2 we want to get the adjusted address, we can do that using the target function. Ref targetFunction = m_data->GetAnalysisFunction(targetPlatform, symbolAddress); - if (targetFunction && type) - targetFunction->ApplyAutoDiscoveredType(type); + if (targetFunction && type.GetValue()) + targetFunction->ApplyAutoDiscoveredType(type.GetValue()); auto adjustedSym = new Symbol(FunctionSymbol, symbol->GetShortName(), symbol->GetFullName(), symbol->GetRawName(), symbolAddress); m_data->DefineAutoSymbol(adjustedSym); -- cgit v1.3.1