From c4ba6d79ae3b96d56cc6b3744e7c64e004ecd161 Mon Sep 17 00:00:00 2001
From: Mason Reed <mason@vector35.com>
Date: Tue, 21 Apr 2026 18:10:51 -0700
Subject: [Rust] Refactor `binary_view` module

- Remove the "viral" `BinaryViewExt` trait and its blanket impl
- Split up the binary view type from the custom trait impl
- Simplify and fix bugs regarding custom binary view initialization
- Rewrite Minidump binary view example, parses the PE headers to create proper sections now
- Add some extra documentation
- Add unit test for custom binary view
---
 plugins/idb_import/src/commands/load_file.rs | 2 +-
 plugins/idb_import/src/mapper.rs             | 2 +-
 plugins/idb_import/src/types.rs              | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

(limited to 'plugins/idb_import/src')

diff --git a/plugins/idb_import/src/commands/load_file.rs b/plugins/idb_import/src/commands/load_file.rs
index 67416e61..ef773c6a 100644
--- a/plugins/idb_import/src/commands/load_file.rs
+++ b/plugins/idb_import/src/commands/load_file.rs
@@ -1,7 +1,7 @@
 use crate::commands::LoadFileField;
 use crate::mapper::IDBMapper;
 use crate::parse::IDBFileParser;
-use binaryninja::binary_view::{BinaryView, BinaryViewExt};
+use binaryninja::binary_view::BinaryView;
 use binaryninja::command::Command;
 use binaryninja::interaction::Form;
 use std::fs::File;
diff --git a/plugins/idb_import/src/mapper.rs b/plugins/idb_import/src/mapper.rs
index 36c980da..530fef1f 100644
--- a/plugins/idb_import/src/mapper.rs
+++ b/plugins/idb_import/src/mapper.rs
@@ -6,7 +6,7 @@ use crate::parse::{
 };
 use crate::translate::TILTranslator;
 use binaryninja::architecture::Architecture;
-use binaryninja::binary_view::{BinaryView, BinaryViewBase, BinaryViewExt};
+use binaryninja::binary_view::{BinaryView, BinaryViewBase};
 use binaryninja::qualified_name::QualifiedName;
 use binaryninja::rc::Ref;
 use binaryninja::section::{SectionBuilder, Semantics};
diff --git a/plugins/idb_import/src/types.rs b/plugins/idb_import/src/types.rs
index 933fec12..cbd37f66 100644
--- a/plugins/idb_import/src/types.rs
+++ b/plugins/idb_import/src/types.rs
@@ -3,7 +3,7 @@ use std::num::{NonZeroU16, NonZeroU8};
 
 use anyhow::{anyhow, Result};
 use binaryninja::architecture::{Architecture, ArchitectureExt, CoreArchitecture};
-use binaryninja::binary_view::{BinaryView, BinaryViewExt};
+use binaryninja::binary_view::{BinaryView};
 use binaryninja::calling_convention::CoreCallingConvention;
 use binaryninja::confidence::Conf;
 use binaryninja::rc::Ref;
-- 
cgit v1.3.1