From 0c572b1343d1e98574b7bc46169947f2dd5a257d Mon Sep 17 00:00:00 2001 From: Mark Rowe Date: Tue, 29 Jul 2025 16:20:49 -0700 Subject: [Mac] Consistently specify rpaths for plug-ins C++ plug-ins now consistently use the `plugin_rpath` or `ui_plugin_rpath` macros to ensure they have `SKIP_BUILD_RPATH` set when building on Mac (i.e., no `LC_RPATH` is added). Rust plug-ins have their build.rs updated to only specify `-Wl,-rpath` when building for Linux. It is not needed on macOS. On macOS we instead explicitly specify an `@rpath`-relative install name. This doesn't change any behavior, but avoids leaving an absolute path as the library's install name and is consistent with CMake's behavior for C++ plug-ins. --- plugins/idb_import/build.rs | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) (limited to 'plugins/idb_import') diff --git a/plugins/idb_import/build.rs b/plugins/idb_import/build.rs index ed6cec7d..97e3e7f5 100644 --- a/plugins/idb_import/build.rs +++ b/plugins/idb_import/build.rs @@ -5,11 +5,18 @@ fn main() { println!("cargo::rustc-link-lib=dylib=binaryninjacore"); println!("cargo::rustc-link-search={}", link_path.to_str().unwrap()); - #[cfg(not(target_os = "windows"))] + #[cfg(target_os = "linux")] { println!( "cargo::rustc-link-arg=-Wl,-rpath,{0},-L{0}", link_path.to_string_lossy() ); } + + #[cfg(target_os = "macos")] + { + let crate_name = std::env::var("CARGO_PKG_NAME").expect("CARGO_PKG_NAME not set"); + let lib_name = crate_name.replace('-', "_"); + println!("cargo::rustc-link-arg=-Wl,-install_name,@rpath/lib{}.dylib", lib_name); + } } -- cgit v1.3.1