From c4ba6d79ae3b96d56cc6b3744e7c64e004ecd161 Mon Sep 17 00:00:00 2001 From: Mason Reed Date: Tue, 21 Apr 2026 18:10:51 -0700 Subject: [Rust] Refactor `binary_view` module - Remove the "viral" `BinaryViewExt` trait and its blanket impl - Split up the binary view type from the custom trait impl - Simplify and fix bugs regarding custom binary view initialization - Rewrite Minidump binary view example, parses the PE headers to create proper sections now - Add some extra documentation - Add unit test for custom binary view --- plugins/warp/src/convert/symbol.rs | 2 +- plugins/warp/src/convert/types.rs | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) (limited to 'plugins/warp/src/convert') diff --git a/plugins/warp/src/convert/symbol.rs b/plugins/warp/src/convert/symbol.rs index 0107cff5..5d794d30 100644 --- a/plugins/warp/src/convert/symbol.rs +++ b/plugins/warp/src/convert/symbol.rs @@ -1,4 +1,4 @@ -use binaryninja::binary_view::{BinaryView, BinaryViewExt}; +use binaryninja::binary_view::BinaryView; use binaryninja::rc::Ref as BNRef; use binaryninja::symbol::Symbol as BNSymbol; use binaryninja::symbol::SymbolType as BNSymbolType; diff --git a/plugins/warp/src/convert/types.rs b/plugins/warp/src/convert/types.rs index abfa3bc9..6969ac67 100644 --- a/plugins/warp/src/convert/types.rs +++ b/plugins/warp/src/convert/types.rs @@ -490,7 +490,6 @@ pub fn to_bn_type(arch: Option, ty: &Type) -> BNRef #[cfg(test)] mod tests { use super::*; - use binaryninja::binary_view::BinaryViewExt; use binaryninja::headless::Session; use std::path::PathBuf; use warp::r#type::guid::TypeGUID; -- cgit v1.3.1