From 2303f75b080f6dd0c9a5c669a71f64ce830f5650 Mon Sep 17 00:00:00 2001 From: Mark Rowe Date: Mon, 11 Aug 2025 10:42:07 -0700 Subject: Rewrite Obj-C workflow in Rust This is functionally equivalent to the previous workflow_objc, with the following changes: 1. It mutates the `core.function.metaAnalysis` workflow rather than registering a new named workflow. The activities now all check for the presence of the Objective-C metadata added by `ObjCProcessor` to determine whether they should do work, rather than relying on `MachoView` to override the function workflow when Objective-C metadata is present. This fixes https://github.com/Vector35/binaryninja-api/issues/6779. 2. The auto-inlining of `objc_msgSend` selector stub functions is performed in a separate activity from the processing of `objc_msgSend` call sites. The selector stub inlining activity is configured so that it does not run in `DSCView` as the shared cache needs different behavior for stub functions more generally that `SharedCacheWorkflow` already provides. 3. The way that types like `id` and `SEL` are referenced is fixed so that they show up as `id` rather than `objc_struct*`. This also replaces the Objective-C portion of the shared cache's workflow, and incorporates several bug fixes that had been applied to it but not the standalone Objective-C workflow. --- plugins/warp/src/plugin.rs | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) (limited to 'plugins/warp/src/plugin.rs') diff --git a/plugins/warp/src/plugin.rs b/plugins/warp/src/plugin.rs index ee778062..7a2bdcff 100644 --- a/plugins/warp/src/plugin.rs +++ b/plugins/warp/src/plugin.rs @@ -12,9 +12,9 @@ use binaryninja::background_task::BackgroundTask; use binaryninja::command::{ register_command, register_command_for_function, register_command_for_project, }; +use binaryninja::is_ui_enabled; use binaryninja::logger::Logger; use binaryninja::settings::Settings; -use binaryninja::{add_optional_plugin_dependency, is_ui_enabled}; use log::LevelFilter; use reqwest::StatusCode; @@ -200,9 +200,3 @@ pub extern "C" fn CorePluginInit() -> bool { true } - -#[unsafe(no_mangle)] -pub extern "C" fn CorePluginDependencies() { - // TODO: Remove this once the objectivec workflow is registered on the meta workflow. - add_optional_plugin_dependency("workflow_objc"); -} -- cgit v1.3.1