From 1d25b8cb9304f53f80d1df960341d7c21d40ab13 Mon Sep 17 00:00:00 2001 From: Mason Reed Date: Wed, 6 Aug 2025 21:07:02 -0400 Subject: [WARP] Move symbol and comment application to when matched functions are inserted Instead of applying symbols and comments in the applier step, we will do it when the matched function is identified. This has the side effect that if you turn off the apply activity names and comments will still be applied, more work to be done later. --- plugins/warp/src/plugin/ffi/function.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'plugins/warp/src/plugin/ffi/function.rs') diff --git a/plugins/warp/src/plugin/ffi/function.rs b/plugins/warp/src/plugin/ffi/function.rs index a7ec6593..7563bd96 100644 --- a/plugins/warp/src/plugin/ffi/function.rs +++ b/plugins/warp/src/plugin/ffi/function.rs @@ -67,7 +67,7 @@ pub unsafe extern "C" fn BNWARPFunctionApply( let analysis_function = Function::from_raw(analysis_function); match function.is_null() { false => { - // Set the matched function to `function` and return previous. + // Set the matched function to `function`. let matched_function = ManuallyDrop::new(Arc::from_raw(function)); insert_cached_function_match( &analysis_function, @@ -75,7 +75,7 @@ pub unsafe extern "C" fn BNWARPFunctionApply( ) } true => { - // We are removing the previous match and returning it. + // We are removing the previous match. insert_cached_function_match(&analysis_function, None) } }; -- cgit v1.3.1