From 3e24f6ab0b373d8718e26a19ac296044cc0d19c6 Mon Sep 17 00:00:00 2001 From: Mason Reed Date: Tue, 7 Oct 2025 14:30:37 -0400 Subject: [WARP] Improved fetch dialog UX - Respects views fetch batch size and allowed tags - Saves and loads from the view settings instead of qt settings --- plugins/warp/ui/matches.cpp | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) (limited to 'plugins/warp/ui/matches.cpp') diff --git a/plugins/warp/ui/matches.cpp b/plugins/warp/ui/matches.cpp index 2345a7ea..b03d72c6 100644 --- a/plugins/warp/ui/matches.cpp +++ b/plugins/warp/ui/matches.cpp @@ -110,13 +110,6 @@ WarpCurrentFunctionWidget::WarpCurrentFunctionWidget() void WarpCurrentFunctionWidget::SetFetcher(std::shared_ptr fetcher) { m_fetcher = fetcher; - // TODO: We need to remove the completion callback from the previously set fetcher. - m_fetcher->AddCompletionCallback([this]() { - // TODO: This is a little bit underspecified, we may end up updating more than strictly necessary. - // Once this function has been fetched, we need to update the matches for this widget. - UpdateMatches(); - return KeepCallback; - }); } void WarpCurrentFunctionWidget::SetCurrentFunction(FunctionRef current) @@ -136,7 +129,8 @@ void WarpCurrentFunctionWidget::SetCurrentFunction(FunctionRef current) { BinaryNinja::WorkerPriorityEnqueue([this]() { BinaryNinja::Ref bgTask = new BinaryNinja::BackgroundTask("Fetching WARP Functions...", true); - m_fetcher->FetchPendingFunctions(); + const auto allowedTags = GetAllowedTagsFromView(m_current->GetView()); + m_fetcher->FetchPendingFunctions(allowedTags); bgTask->Finish(); }); } -- cgit v1.3.1