From 3e24f6ab0b373d8718e26a19ac296044cc0d19c6 Mon Sep 17 00:00:00 2001 From: Mason Reed Date: Tue, 7 Oct 2025 14:30:37 -0400 Subject: [WARP] Improved fetch dialog UX - Respects views fetch batch size and allowed tags - Saves and loads from the view settings instead of qt settings --- plugins/warp/ui/plugin.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'plugins/warp/ui/plugin.cpp') diff --git a/plugins/warp/ui/plugin.cpp b/plugins/warp/ui/plugin.cpp index d4860b91..b1cc9a5b 100644 --- a/plugins/warp/ui/plugin.cpp +++ b/plugins/warp/ui/plugin.cpp @@ -163,6 +163,9 @@ WarpSidebarWidget::WarpSidebarWidget(BinaryViewRef data) : SidebarWidget("WARP") tabWidget->addTab(matchedFrame, "Matched Functions"); tabWidget->addTab(containerFrame, "Containers"); + layout->addWidget(tabWidget); + this->setLayout(layout); + // Do a full update if analysis has been done, otherwise we may persist old data and not have new data. m_analysisEvent = new AnalysisCompletionEvent(m_data, [this]() { ExecuteOnMainThread([this]() { @@ -170,15 +173,12 @@ WarpSidebarWidget::WarpSidebarWidget(BinaryViewRef data) : SidebarWidget("WARP") }); }); - std::shared_ptr fetcher = WarpFetcher::Global(); + const std::shared_ptr fetcher = WarpFetcher::Global(); fetcher->AddCompletionCallback([this]() { Update(); return KeepCallback; }); - layout->addWidget(tabWidget); - this->setLayout(layout); - // NOTE: This fetcher is shared with the fetch dialog that is constructed on initialization of this plugin. m_currentFunctionWidget->SetFetcher(fetcher); } -- cgit v1.3.1