From 2303f75b080f6dd0c9a5c669a71f64ce830f5650 Mon Sep 17 00:00:00 2001 From: Mark Rowe Date: Mon, 11 Aug 2025 10:42:07 -0700 Subject: Rewrite Obj-C workflow in Rust This is functionally equivalent to the previous workflow_objc, with the following changes: 1. It mutates the `core.function.metaAnalysis` workflow rather than registering a new named workflow. The activities now all check for the presence of the Objective-C metadata added by `ObjCProcessor` to determine whether they should do work, rather than relying on `MachoView` to override the function workflow when Objective-C metadata is present. This fixes https://github.com/Vector35/binaryninja-api/issues/6779. 2. The auto-inlining of `objc_msgSend` selector stub functions is performed in a separate activity from the processing of `objc_msgSend` call sites. The selector stub inlining activity is configured so that it does not run in `DSCView` as the shared cache needs different behavior for stub functions more generally that `SharedCacheWorkflow` already provides. 3. The way that types like `id` and `SEL` are referenced is fixed so that they show up as `id` rather than `objc_struct*`. This also replaces the Objective-C portion of the shared cache's workflow, and incorporates several bug fixes that had been applied to it but not the standalone Objective-C workflow. --- plugins/workflow_objc/GlobalState.cpp | 102 ---------------------------------- 1 file changed, 102 deletions(-) delete mode 100644 plugins/workflow_objc/GlobalState.cpp (limited to 'plugins/workflow_objc/GlobalState.cpp') diff --git a/plugins/workflow_objc/GlobalState.cpp b/plugins/workflow_objc/GlobalState.cpp deleted file mode 100644 index 6aff3670..00000000 --- a/plugins/workflow_objc/GlobalState.cpp +++ /dev/null @@ -1,102 +0,0 @@ -/* - * Copyright (c) 2022-2023 Jon Palmisciano. All rights reserved. - * - * Use of this source code is governed by the BSD 3-Clause license; the full - * terms of the license can be found in the LICENSE.txt file. - */ - -#include "GlobalState.h" - -#include -#include -#include - -static std::unordered_map g_messageHandlers; -static std::shared_mutex g_messageHandlerLock; -static std::unordered_map g_viewInfos; -static std::shared_mutex g_viewInfoLock; -static std::set g_ignoredViews; - - -MessageHandler* GlobalState::messageHandler(BinaryViewRef bv) -{ - std::unique_lock lock(g_messageHandlerLock); - auto messageHandler = g_messageHandlers.find(id(bv)); - if (messageHandler != g_messageHandlers.end()) - return messageHandler->second; - auto newMessageHandler = new MessageHandler(bv); - g_messageHandlers[id(bv)] = newMessageHandler; - return newMessageHandler; -} - -BinaryViewID GlobalState::id(BinaryViewRef bv) -{ - return bv->GetFile()->GetSessionId(); -} - -void GlobalState::addIgnoredView(BinaryViewRef bv) -{ - g_ignoredViews.insert(id(std::move(bv))); -} - -bool GlobalState::viewIsIgnored(BinaryViewRef bv) -{ - return g_ignoredViews.count(id(std::move(bv))) > 0; -} - -SharedAnalysisInfo GlobalState::analysisInfo(BinaryViewRef data) -{ - { - std::shared_lock lock(g_viewInfoLock); - if (auto it = g_viewInfos.find(id(data)); it != g_viewInfos.end()) - if (data->GetStart() == it->second->imageBase) - return it->second; - } - - std::unique_lock lock(g_viewInfoLock); - SharedAnalysisInfo info = std::make_shared(); - info->imageBase = data->GetStart(); - - if (auto objcStubs = data->GetSectionByName("__objc_stubs")) - { - info->objcStubsStartEnd = {objcStubs->GetStart(), objcStubs->GetEnd()}; - info->hasObjcStubs = true; - } - - auto meta = data->QueryMetadata("Objective-C"); - if (!meta) - { - g_viewInfos[id(data)] = info; - return info; - } - - auto metaKVS = meta->GetKeyValueStore(); - if (metaKVS["version"]->GetUnsignedInteger() != 1) - { - BinaryNinja::LogError("workflow_objc: Invalid metadata version received!"); - g_viewInfos[id(data)] = info; - return info; - } - for (const auto& selAndImps : metaKVS["selRefImplementations"]->GetArray()) - info->selRefToImp[selAndImps->GetArray()[0]->GetUnsignedInteger()] = selAndImps->GetArray()[1]->GetUnsignedIntegerList(); - for (const auto& selAndImps : metaKVS["selImplementations"]->GetArray()) - info->selToImp[selAndImps->GetArray()[0]->GetUnsignedInteger()] = selAndImps->GetArray()[1]->GetUnsignedIntegerList(); - - g_viewInfos[id(data)] = info; - return info; -} - -bool GlobalState::hasAnalysisInfo(BinaryViewRef data) -{ - return data->QueryMetadata("Objective-C") != nullptr; -} - -bool GlobalState::hasFlag(BinaryViewRef bv, const std::string& flag) -{ - return bv->QueryMetadata(flag); -} - -void GlobalState::setFlag(BinaryViewRef bv, const std::string& flag) -{ - bv->StoreMetadata(flag, new BinaryNinja::Metadata("YES")); -} -- cgit v1.3.1