From 2303f75b080f6dd0c9a5c669a71f64ce830f5650 Mon Sep 17 00:00:00 2001 From: Mark Rowe Date: Mon, 11 Aug 2025 10:42:07 -0700 Subject: Rewrite Obj-C workflow in Rust This is functionally equivalent to the previous workflow_objc, with the following changes: 1. It mutates the `core.function.metaAnalysis` workflow rather than registering a new named workflow. The activities now all check for the presence of the Objective-C metadata added by `ObjCProcessor` to determine whether they should do work, rather than relying on `MachoView` to override the function workflow when Objective-C metadata is present. This fixes https://github.com/Vector35/binaryninja-api/issues/6779. 2. The auto-inlining of `objc_msgSend` selector stub functions is performed in a separate activity from the processing of `objc_msgSend` call sites. The selector stub inlining activity is configured so that it does not run in `DSCView` as the shared cache needs different behavior for stub functions more generally that `SharedCacheWorkflow` already provides. 3. The way that types like `id` and `SEL` are referenced is fixed so that they show up as `id` rather than `objc_struct*`. This also replaces the Objective-C portion of the shared cache's workflow, and incorporates several bug fixes that had been applied to it but not the standalone Objective-C workflow. --- plugins/workflow_objc/GlobalState.h | 79 ------------------------------------- 1 file changed, 79 deletions(-) delete mode 100644 plugins/workflow_objc/GlobalState.h (limited to 'plugins/workflow_objc/GlobalState.h') diff --git a/plugins/workflow_objc/GlobalState.h b/plugins/workflow_objc/GlobalState.h deleted file mode 100644 index 38aeb384..00000000 --- a/plugins/workflow_objc/GlobalState.h +++ /dev/null @@ -1,79 +0,0 @@ -/* - * Copyright (c) 2022-2023 Jon Palmisciano. All rights reserved. - * - * Use of this source code is governed by the BSD 3-Clause license; the full - * terms of the license can be found in the LICENSE.txt file. - */ - -#pragma once - -#include -#include "BinaryNinja.h" - -#include "MessageHandler.h" - -/** - * Namespace to hold metadata flag key constants. - */ -namespace Flag { - -constexpr auto DidRunWorkflow = "objectiveNinja.didRunWorkflow"; -constexpr auto DidRunStructureAnalysis = "objectiveNinja.didRunStructureAnalysis"; - -} - -struct AnalysisInfo { - std::uint64_t imageBase; - bool hasObjcStubs = false; - std::pair objcStubsStartEnd; - std::unordered_map> selRefToImp; - std::unordered_map> selToImp; -}; - -typedef std::shared_ptr SharedAnalysisInfo; - -/** - * Global state/storage interface. - */ -class GlobalState { - /** - * Get the ID for a view. - */ - static BinaryViewID id(BinaryViewRef); - -public: - /** - * Get the analysis info for a view. - */ - static SharedAnalysisInfo analysisInfo(BinaryViewRef); - - /** - * Get ObjC Message Handler for a view - */ - static MessageHandler* messageHandler(BinaryViewRef); - - /** - * Check if analysis info exists for a view. - */ - static bool hasAnalysisInfo(BinaryViewRef); - - /** - * Add a view to the list of ignored views. - */ - static void addIgnoredView(BinaryViewRef); - - /** - * Check if a view is ignored. - */ - static bool viewIsIgnored(BinaryViewRef); - - /** - * Check if the a metadata flag is present for a view. - */ - static bool hasFlag(BinaryViewRef, const std::string&); - - /** - * Set a metadata flag for a view. - */ - static void setFlag(BinaryViewRef, const std::string&); -}; -- cgit v1.3.1