From 2303f75b080f6dd0c9a5c669a71f64ce830f5650 Mon Sep 17 00:00:00 2001 From: Mark Rowe Date: Mon, 11 Aug 2025 10:42:07 -0700 Subject: Rewrite Obj-C workflow in Rust This is functionally equivalent to the previous workflow_objc, with the following changes: 1. It mutates the `core.function.metaAnalysis` workflow rather than registering a new named workflow. The activities now all check for the presence of the Objective-C metadata added by `ObjCProcessor` to determine whether they should do work, rather than relying on `MachoView` to override the function workflow when Objective-C metadata is present. This fixes https://github.com/Vector35/binaryninja-api/issues/6779. 2. The auto-inlining of `objc_msgSend` selector stub functions is performed in a separate activity from the processing of `objc_msgSend` call sites. The selector stub inlining activity is configured so that it does not run in `DSCView` as the shared cache needs different behavior for stub functions more generally that `SharedCacheWorkflow` already provides. 3. The way that types like `id` and `SEL` are referenced is fixed so that they show up as `id` rather than `objc_struct*`. This also replaces the Objective-C portion of the shared cache's workflow, and incorporates several bug fixes that had been applied to it but not the standalone Objective-C workflow. --- plugins/workflow_objc/Workflow.h | 48 ---------------------------------------- 1 file changed, 48 deletions(-) delete mode 100644 plugins/workflow_objc/Workflow.h (limited to 'plugins/workflow_objc/Workflow.h') diff --git a/plugins/workflow_objc/Workflow.h b/plugins/workflow_objc/Workflow.h deleted file mode 100644 index 4479a8a7..00000000 --- a/plugins/workflow_objc/Workflow.h +++ /dev/null @@ -1,48 +0,0 @@ -/* - * Copyright (c) 2022-2023 Jon Palmisciano. All rights reserved. - * - * Use of this source code is governed by the BSD 3-Clause license; the full - * terms of the license can be found in the LICENSE.txt file. - */ - -#pragma once - -#include "BinaryNinja.h" - -/** - * Namespace to hold activity ID constants. - */ -namespace ActivityID { - -constexpr auto ResolveMethodCalls = "core.function.objectiveC.resolveMethodCalls"; - -} - -/** - * Workflow-related procedures. - */ -class Workflow { - - /** - * Attempt to rewrite the `objc_msgSend` call at `insnIndex` with a direct - * call to the requested method's implementation. - * - * @param insnIndex The index of the `LLIL_CALL` instruction to rewrite - */ - static bool rewriteMethodCall(LLILFunctionRef, size_t insnIndex); - -public: - /** - * Attempt to inline all `objc_msgSend` calls in the given analysis context. - */ - static void inlineMethodCalls(AnalysisContextRef); - - /** - * Register the Objective Ninja workflow and all activities. - * - * This is named a bit strangely because `register` is a keyword in C++ and - * therefore an invalid method name, and I refuse to misspell it to appease - * the compiler and avoid the conflict. - */ - static void registerActivities(); -}; -- cgit v1.3.1