From 2303f75b080f6dd0c9a5c669a71f64ce830f5650 Mon Sep 17 00:00:00 2001 From: Mark Rowe Date: Mon, 11 Aug 2025 10:42:07 -0700 Subject: Rewrite Obj-C workflow in Rust This is functionally equivalent to the previous workflow_objc, with the following changes: 1. It mutates the `core.function.metaAnalysis` workflow rather than registering a new named workflow. The activities now all check for the presence of the Objective-C metadata added by `ObjCProcessor` to determine whether they should do work, rather than relying on `MachoView` to override the function workflow when Objective-C metadata is present. This fixes https://github.com/Vector35/binaryninja-api/issues/6779. 2. The auto-inlining of `objc_msgSend` selector stub functions is performed in a separate activity from the processing of `objc_msgSend` call sites. The selector stub inlining activity is configured so that it does not run in `DSCView` as the shared cache needs different behavior for stub functions more generally that `SharedCacheWorkflow` already provides. 3. The way that types like `id` and `SEL` are referenced is fixed so that they show up as `id` rather than `objc_struct*`. This also replaces the Objective-C portion of the shared cache's workflow, and incorporates several bug fixes that had been applied to it but not the standalone Objective-C workflow. --- .../workflow_objc/src/activities/inline_stubs.rs | 26 ++++++++++++++++++++++ 1 file changed, 26 insertions(+) create mode 100644 plugins/workflow_objc/src/activities/inline_stubs.rs (limited to 'plugins/workflow_objc/src/activities/inline_stubs.rs') diff --git a/plugins/workflow_objc/src/activities/inline_stubs.rs b/plugins/workflow_objc/src/activities/inline_stubs.rs new file mode 100644 index 00000000..daae9baa --- /dev/null +++ b/plugins/workflow_objc/src/activities/inline_stubs.rs @@ -0,0 +1,26 @@ +use binaryninja::workflow::AnalysisContext; + +use crate::{metadata::GlobalState, Error}; + +// If this function is within a section known to contain Objective-C stubs, +// mark it as being inlined during analysis. +pub fn process(ac: &AnalysisContext) -> Result<(), Error> { + let view = ac.view(); + if GlobalState::should_ignore_view(&view) { + return Ok(()); + } + + let func = ac.function(); + let Some(objc_stubs) = GlobalState::analysis_info(&view) + .as_ref() + .and_then(|info| info.objc_stubs.clone()) + else { + return Ok(()); + }; + + if objc_stubs.contains(&func.start()) { + func.set_auto_inline_during_analysis(true); + } + + Ok(()) +} -- cgit v1.3.1