From 01a224425d2a90e660bbfffe8d1cbc6b93da24bd Mon Sep 17 00:00:00 2001 From: Mason Reed Date: Mon, 27 Jan 2025 16:56:15 -0500 Subject: Fix some rust race conditions and comment some likely suspects FYI The binary view saving stuff can deadlock right now, so we document that now :/ --- plugins/warp/src/plugin.rs | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'plugins') diff --git a/plugins/warp/src/plugin.rs b/plugins/warp/src/plugin.rs index 86c4bc7b..b84173f7 100644 --- a/plugins/warp/src/plugin.rs +++ b/plugins/warp/src/plugin.rs @@ -39,6 +39,10 @@ fn get_warp_tag_type(view: &BinaryView) -> Ref { // TODO: Rename to markup_function or something. pub fn on_matched_function(function: &Function, matched: &WarpFunction) { let view = function.view(); + // TODO: Using user symbols here is problematic + // TODO: For one they queue up a bunch of main thread actions + // TODO: Secondly by queueing up those main thread actions if you attempt to save the file + // TODO: Before the undo actions are done completing view.define_user_symbol(&to_bn_symbol_at_address( &view, &matched.symbol, -- cgit v1.3.1