From 36982c4208d8aaa369211ec2d5f3aad3b2f57ee7 Mon Sep 17 00:00:00 2001 From: Mason Reed Date: Mon, 28 Oct 2024 21:21:49 -0400 Subject: Fix WARP symbol conversion using the wrong modifiers --- plugins/warp/src/convert.rs | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) (limited to 'plugins') diff --git a/plugins/warp/src/convert.rs b/plugins/warp/src/convert.rs index cbb47858..85a288f4 100644 --- a/plugins/warp/src/convert.rs +++ b/plugins/warp/src/convert.rs @@ -53,12 +53,11 @@ pub fn from_bn_symbol(raw_symbol: &BNSymbol) -> Symbol { BNSymbolType::LocalLabel => { todo!() } - // BN External is our Exported BNSymbolType::External => Symbol::new( symbol_name, - // TODO: Data? - SymbolClass::Data, - SymbolModifiers::Exported, + // TODO: External data? + SymbolClass::Function, + SymbolModifiers::External, ), BNSymbolType::ImportedData => { Symbol::new(symbol_name, SymbolClass::Data, SymbolModifiers::External) @@ -68,10 +67,10 @@ pub fn from_bn_symbol(raw_symbol: &BNSymbol) -> Symbol { SymbolClass::Function, SymbolModifiers::default(), ), - // BN Imported is our External BNSymbolType::ImportedFunction => Symbol::new( symbol_name, SymbolClass::Function, + // TODO: Exported? SymbolModifiers::External, ), } -- cgit v1.3.1