From e224042bd3b903450113204b80ce4c4bded92f21 Mon Sep 17 00:00:00 2001 From: Mason Reed Date: Wed, 30 Oct 2024 14:31:25 -0400 Subject: WARP: Fix unhandled symbol conversion --- plugins/warp/src/convert.rs | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) (limited to 'plugins') diff --git a/plugins/warp/src/convert.rs b/plugins/warp/src/convert.rs index 85a288f4..728dd599 100644 --- a/plugins/warp/src/convert.rs +++ b/plugins/warp/src/convert.rs @@ -37,7 +37,12 @@ pub fn from_bn_symbol(raw_symbol: &BNSymbol) -> Symbol { let symbol_name = raw_symbol.raw_name().to_string(); match raw_symbol.sym_type() { BNSymbolType::ImportAddress => { - todo!() + Symbol::new( + symbol_name, + SymbolClass::Function, + // TODO: External = symbolic i guess + SymbolModifiers::External, + ) } BNSymbolType::Data => { Symbol::new( @@ -48,10 +53,16 @@ pub fn from_bn_symbol(raw_symbol: &BNSymbol) -> Symbol { ) } BNSymbolType::Symbolic => { - todo!() + Symbol::new( + symbol_name, + SymbolClass::Function, + // TODO: External = symbolic i guess + SymbolModifiers::External, + ) } BNSymbolType::LocalLabel => { - todo!() + // TODO: This is a placeholder for another symbol. + Symbol::new(symbol_name, SymbolClass::Data, SymbolModifiers::External) } BNSymbolType::External => Symbol::new( symbol_name, -- cgit v1.3.1