From ff72f3be107e94a0be41a1e7ba113000a4e95089 Mon Sep 17 00:00:00 2001 From: Mark Rowe Date: Mon, 11 Aug 2025 15:45:38 -0700 Subject: Deprecate Workflow::Instance in favor of Workflow::Get and Workflow::GetOrCreate Calls to `Workflow::Instance` that were looking up a built-in workflow name are updated to use `Workflow::Get`. Others use `Workflow::GetOrCreate`. --- plugins/efi_resolver/src/Plugin.cpp | 2 +- plugins/rtti/plugin.cpp | 2 +- plugins/workflow_objc/Workflow.cpp | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) (limited to 'plugins') diff --git a/plugins/efi_resolver/src/Plugin.cpp b/plugins/efi_resolver/src/Plugin.cpp index e26ec171..2f43c4f3 100644 --- a/plugins/efi_resolver/src/Plugin.cpp +++ b/plugins/efi_resolver/src/Plugin.cpp @@ -61,7 +61,7 @@ extern "C" BINARYNINJAPLUGIN bool CorePluginInit() { EfiGuidRenderer::Register(); - auto workflow = Workflow::Instance("core.module.metaAnalysis")->Clone(); + auto workflow = Workflow::Get("core.module.metaAnalysis")->Clone(); workflow->RegisterActivity(R"~({ "title": "EFI Resolver", "name": "analysis.efi.efiResolver", diff --git a/plugins/rtti/plugin.cpp b/plugins/rtti/plugin.cpp index 6f1a3e2f..721a4418 100644 --- a/plugins/rtti/plugin.cpp +++ b/plugins/rtti/plugin.cpp @@ -91,7 +91,7 @@ extern "C" { // TODO: 2. Identify if the function is unique to a class, renaming and retyping if true // TODO: 3. Identify functions which address a VFT and are probably a constructor (alloc use), retyping if true // TODO: 4. Identify functions which address a VFT and are probably a deconstructor (free use), retyping if true - Ref rttiMetaWorkflow = Workflow::Instance("core.module.metaAnalysis")->Clone(); + Ref rttiMetaWorkflow = Workflow::Get("core.module.metaAnalysis")->Clone(); // Add RTTI analysis. rttiMetaWorkflow->RegisterActivity(R"~({ diff --git a/plugins/workflow_objc/Workflow.cpp b/plugins/workflow_objc/Workflow.cpp index e0986943..fb65f29a 100644 --- a/plugins/workflow_objc/Workflow.cpp +++ b/plugins/workflow_objc/Workflow.cpp @@ -307,7 +307,7 @@ static constexpr auto WorkflowInfo = R"({ void Workflow::registerActivities() { - const auto wf = BinaryNinja::Workflow::Instance("core.function.baseAnalysis")->Clone("core.function.objectiveC"); + const auto wf = BinaryNinja::Workflow::Get("core.function.baseAnalysis")->Clone("core.function.objectiveC"); wf->RegisterActivity(new BinaryNinja::Activity( ActivityID::ResolveMethodCalls, &Workflow::inlineMethodCalls)); wf->InsertAfter("core.function.translateTailCalls", ActivityID::ResolveMethodCalls); -- cgit v1.3.1