From 1d21f2de35633113c38692a4fcb7e0481c96fd08 Mon Sep 17 00:00:00 2001 From: KyleMiles Date: Fri, 7 Oct 2022 15:55:43 -0400 Subject: Remove default load settings; Move settings `analysis.debugInfoInternal` and `loader.debugInfoExternal` to `analysis.debugInfo.internal` and `analysis.debugInfo.external` --- python/binaryview.py | 24 ++++++------------------ 1 file changed, 6 insertions(+), 18 deletions(-) (limited to 'python/binaryview.py') diff --git a/python/binaryview.py b/python/binaryview.py index 02255b95..02b1cc53 100644 --- a/python/binaryview.py +++ b/python/binaryview.py @@ -1956,7 +1956,7 @@ class BinaryView: binaryninja._init_plugins() if file_metadata is None: file_metadata = filemetadata.FileMetadata() - _handle = core.BNCreateBinaryDataView(file_metadata.handle, True) + _handle = core.BNCreateBinaryDataView(file_metadata.handle) self._file = filemetadata.FileMetadata(handle=core.BNNewFileReference(file_metadata.handle)) else: binaryninja._init_plugins() @@ -2223,11 +2223,11 @@ class BinaryView: if isinstance(src, fileaccessor.FileAccessor): if file_metadata is None: file_metadata = filemetadata.FileMetadata() - view = core.BNCreateBinaryDataViewFromFile(file_metadata.handle, src._cb, True) + view = core.BNCreateBinaryDataViewFromFile(file_metadata.handle, src._cb) else: if file_metadata is None: file_metadata = filemetadata.FileMetadata(str(src)) - view = core.BNCreateBinaryDataViewFromFilename(file_metadata.handle, str(src), True) + view = core.BNCreateBinaryDataViewFromFilename(file_metadata.handle, str(src)) if view is None: return None return BinaryView(file_metadata=file_metadata, handle=view) @@ -2238,12 +2238,12 @@ class BinaryView: if file_metadata is None: file_metadata = filemetadata.FileMetadata() if data is None: - view = core.BNCreateBinaryDataView(file_metadata.handle, True) + view = core.BNCreateBinaryDataView(file_metadata.handle) elif isinstance(data, databuffer.DataBuffer): - view = core.BNCreateBinaryDataViewFromBuffer(file_metadata.handle, data.handle, True) + view = core.BNCreateBinaryDataViewFromBuffer(file_metadata.handle, data.handle) else: buf = databuffer.DataBuffer(data) - view = core.BNCreateBinaryDataViewFromBuffer(file_metadata.handle, buf.handle, True) + view = core.BNCreateBinaryDataViewFromBuffer(file_metadata.handle, buf.handle) if view is None: return None return BinaryView(file_metadata=file_metadata, handle=view) @@ -7808,18 +7808,6 @@ class BinaryView: settings = settings.handle core.BNBinaryViewSetLoadSettings(self.handle, type_name, settings) - def get_default_load_settings(self, type_name: str, settings: settings.Settings) -> None: - """ - ``get_default_load_settings`` retrieve a :py:class:`Settings` object which defines the load settings for the given :py:class:`BinaryViewType` ``type_name`` - - :param str type_name: the :py:class:`BinaryViewType` name - :param Settings settings: the load settings - :rtype: :py:class:`Settings`, or ``None`` - """ - if settings is not None: - settings = settings.handle - core.BNBinaryViewGetDefaultLoadSettings(self.handle, type_name, settings) - def parse_expression(self, expression: str, here: int = 0) -> int: r""" Evaluates a string expression to an integer value. -- cgit v1.3.1