From 1d21f2de35633113c38692a4fcb7e0481c96fd08 Mon Sep 17 00:00:00 2001 From: KyleMiles Date: Fri, 7 Oct 2022 15:55:43 -0400 Subject: Remove default load settings; Move settings `analysis.debugInfoInternal` and `loader.debugInfoExternal` to `analysis.debugInfo.internal` and `analysis.debugInfo.external` --- python/examples/debug_info.py | 2 +- python/examples/mappedview.py | 7 ++----- 2 files changed, 3 insertions(+), 6 deletions(-) (limited to 'python/examples') diff --git a/python/examples/debug_info.py b/python/examples/debug_info.py index 0dd25786..a060e465 100755 --- a/python/examples/debug_info.py +++ b/python/examples/debug_info.py @@ -222,7 +222,7 @@ for p in bn.debuginfo.DebugInfoParser: print(f" {bn.debuginfo.DebugInfoParser[p.name].name}") # Test calling our `is_valid` callback -bv = bn.open_view(filename, options={"loader.debugInfoInternal": False}) +bv = bn.open_view(filename, options={"analysis.debugInfo.internal": False}) if parser.is_valid_for_view(bv): print("Parser is valid") else: diff --git a/python/examples/mappedview.py b/python/examples/mappedview.py index cfefa87a..0b74ce3a 100644 --- a/python/examples/mappedview.py +++ b/python/examples/mappedview.py @@ -53,7 +53,7 @@ class MappedView(BinaryView): def get_load_settings_for_data(cls, data): # This method is optional. If provided this is where the Load Settings for a BinaryViewType are specified. Binary Ninja provides # some default read-only load settings which are: - # ["loader.architecture", "loader.platform", "loader.entryPointOffset", "loader.imageBase", "loader.segments", "loader.sections", "loader.debugInfoInternal", "loader.debugInfoExternal"] + # ["loader.architecture", "loader.platform", "loader.entryPointOffset", "loader.imageBase", "loader.segments", "loader.sections"] # The default load settings are provided for consistency and convenience. # The default load settings are always generated with a read-only indication which is respected by the UI. # The read-only indication is a property that consists of a JSON name/value pair ("readOnly" : true). @@ -75,10 +75,7 @@ class MappedView(BinaryView): load_settings = registered_view.get_default_load_settings_for_data(view) # Specify default load settings that can be overridden (from the UI). - overrides = [ - "loader.architecture", "loader.platform", "loader.entryPointOffset", "loader.imageBase", - "loader.segments", "loader.sections", "loader.debugInfoInternal", "loader.debugInfoExternal" - ] + overrides = ["loader.architecture", "loader.platform", "loader.entryPointOffset", "loader.imageBase", "loader.segments", "loader.sections"] for override in overrides: if load_settings.contains(override): load_settings.update_property(override, json.dumps({'readOnly': False})) -- cgit v1.3.1