From 2d9702f3cbf3a428635c6fd10f1f9ba7880363f3 Mon Sep 17 00:00:00 2001 From: Glenn Smith Date: Sat, 5 Dec 2020 17:34:23 -0500 Subject: Fix tag notification callbacks not giving real python objects --- python/binaryview.py | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) (limited to 'python') diff --git a/python/binaryview.py b/python/binaryview.py index 9d095388..fb01122b 100644 --- a/python/binaryview.py +++ b/python/binaryview.py @@ -288,7 +288,7 @@ class BinaryViewEvent(object): except: binaryninja.log.log_error(traceback.format_exc()) - + class ActiveAnalysisInfo(object): def __init__(self, func, analysis_time, update_count, submit_count): self._func = func @@ -604,11 +604,11 @@ class BinaryDataNotificationCallbacks(object): try: ref_type = tag_ref[0].refType auto_defined = tag_ref[0].autoDefined - tag = tag_ref[0].tag - arch = tag_ref[0].arch - func = tag_ref[0].func + tag = Tag(core.BNNewTagReference(tag_ref[0].tag)) + arch = binaryninja.architecture.CoreArchitecture._from_cache(tag_ref[0].arch) + func = binaryninja.function.Function(self._view, core.BNNewFunctionReference(tag_ref[0].func)) addr = tag_ref[0].addr - self._notify.tag_added(self._view, Tag(core.BNNewTagReference(tag)), ref_type, auto_defined, arch, func, addr) + self._notify.tag_added(self._view, tag, ref_type, auto_defined, arch, func, addr) except: log.log_error(traceback.format_exc()) @@ -616,11 +616,11 @@ class BinaryDataNotificationCallbacks(object): try: ref_type = tag_ref[0].refType auto_defined = tag_ref[0].autoDefined - tag = tag_ref[0].tag - arch = tag_ref[0].arch - func = tag_ref[0].func + tag = Tag(core.BNNewTagReference(tag_ref[0].tag)) + arch = binaryninja.architecture.CoreArchitecture._from_cache(tag_ref[0].arch) + func = binaryninja.function.Function(self._view, core.BNNewFunctionReference(tag_ref[0].func)) addr = tag_ref[0].addr - self._notify.tag_updated(self._view, Tag(core.BNNewTagReference(tag)), ref_type, auto_defined, arch, func, addr) + self._notify.tag_updated(self._view, tag, ref_type, auto_defined, arch, func, addr) except: log.log_error(traceback.format_exc()) @@ -628,11 +628,11 @@ class BinaryDataNotificationCallbacks(object): try: ref_type = tag_ref[0].refType auto_defined = tag_ref[0].autoDefined - tag = tag_ref[0].tag - arch = tag_ref[0].arch - func = tag_ref[0].func + tag = Tag(core.BNNewTagReference(tag_ref[0].tag)) + arch = binaryninja.architecture.CoreArchitecture._from_cache(tag_ref[0].arch) + func = binaryninja.function.Function(self._view, core.BNNewFunctionReference(tag_ref[0].func)) addr = tag_ref[0].addr - self._notify.tag_removed(self._view, Tag(core.BNNewTagReference(tag)), ref_type, auto_defined, arch, func, addr) + self._notify.tag_removed(self._view, tag, ref_type, auto_defined, arch, func, addr) except: log.log_error(traceback.format_exc()) -- cgit v1.3.1