From 1b552d72eff547ef53a4e9af9a95382f9031f681 Mon Sep 17 00:00:00 2001
From: Mason Reed <mason@vector35.com>
Date: Wed, 24 Dec 2025 22:38:17 -0500
Subject: [Rust] Fix `BinaryViewExt::address_comments` leaking and refactor

---
 rust/src/binary_view.rs | 62 +++++++++++++++++++++++++++++++++++++------------
 1 file changed, 47 insertions(+), 15 deletions(-)

(limited to 'rust/src/binary_view.rs')

diff --git a/rust/src/binary_view.rs b/rust/src/binary_view.rs
index 1952c780..4e5c7dfb 100644
--- a/rust/src/binary_view.rs
+++ b/rust/src/binary_view.rs
@@ -1686,22 +1686,27 @@ pub trait BinaryViewExt: BinaryViewBase {
         unsafe { BNRemoveUserDataTag(self.as_ref().handle, addr, tag.handle) }
     }
 
-    fn address_comments(&self) -> BTreeMap<u64, String> {
-        let mut comment_count = 0;
-        let mut result = BTreeMap::new();
-        let addresses;
-        unsafe {
-            let addresses_raw =
-                BNGetGlobalCommentedAddresses(self.as_ref().handle, &mut comment_count);
-            addresses = std::slice::from_raw_parts(addresses_raw, comment_count);
-        }
+    /// Retrieves a list of comment addresses, the comments themselves can then be queried with
+    /// the function [`BinaryViewExt::comment_at`].
+    ///
+    /// If you would rather retrieve the contents of **all** comments at once you can do so with
+    /// the helper function [`BinaryViewExt::comments`].
+    fn comment_references(&self) -> Array<CommentReference> {
+        let mut count = 0;
+        let addresses_raw =
+            unsafe { BNGetGlobalCommentedAddresses(self.as_ref().handle, &mut count) };
+        unsafe { Array::new(addresses_raw, count, ()) }
+    }
 
-        for address in addresses {
-            if let Some(comment) = self.comment_at(*address) {
-                result.insert(*address, comment);
-            }
-        }
-        result
+    /// Retrieves a map of comment addresses to their contents.
+    ///
+    /// This is a helper function that eagerly reads the contents of all comments within the
+    /// view, use [`BinaryViewExt::comment_references`] instead if you do not wish to read all the comments.
+    fn comments(&self) -> BTreeMap<u64, String> {
+        self.comment_references()
+            .iter()
+            .filter_map(|cmt_ref| Some((cmt_ref.start, self.comment_at(cmt_ref.start)?)))
+            .collect()
     }
 
     fn comment_at(&self, addr: u64) -> Option<String> {
@@ -2710,6 +2715,33 @@ where
     }
 }
 
+#[derive(Debug, Copy, Clone, PartialEq, Eq, Hash)]
+pub struct CommentReference {
+    pub start: u64,
+}
+
+impl From<u64> for CommentReference {
+    fn from(start: u64) -> Self {
+        Self { start }
+    }
+}
+
+impl CoreArrayProvider for CommentReference {
+    type Raw = u64;
+    type Context = ();
+    type Wrapped<'a> = Self;
+}
+
+unsafe impl CoreArrayProviderInner for CommentReference {
+    unsafe fn free(raw: *mut Self::Raw, _count: usize, _context: &Self::Context) {
+        BNFreeAddressList(raw)
+    }
+
+    unsafe fn wrap_raw<'a>(raw: &'a Self::Raw, _context: &'a Self::Context) -> Self::Wrapped<'a> {
+        Self::from(*raw)
+    }
+}
+
 #[derive(Debug, Copy, Clone, PartialEq, Eq, Hash)]
 pub struct StringReference {
     pub ty: StringType,
-- 
cgit v1.3.1