From c4ba6d79ae3b96d56cc6b3744e7c64e004ecd161 Mon Sep 17 00:00:00 2001 From: Mason Reed Date: Tue, 21 Apr 2026 18:10:51 -0700 Subject: [Rust] Refactor `binary_view` module - Remove the "viral" `BinaryViewExt` trait and its blanket impl - Split up the binary view type from the custom trait impl - Simplify and fix bugs regarding custom binary view initialization - Rewrite Minidump binary view example, parses the PE headers to create proper sections now - Add some extra documentation - Add unit test for custom binary view --- rust/src/platform.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'rust/src/platform.rs') diff --git a/rust/src/platform.rs b/rust/src/platform.rs index bf135fae..e70e1277 100644 --- a/rust/src/platform.rs +++ b/rust/src/platform.rs @@ -176,7 +176,7 @@ impl Platform { pub fn type_container(&self) -> TypeContainer { let type_container_ptr = NonNull::new(unsafe { BNGetPlatformTypeContainer(self.handle) }); // NOTE: I have no idea how this isn't a UAF, see the note in `TypeContainer::from_raw` - // TODO: We are cloning here for platforms but we dont need to do this for [BinaryViewExt::type_container] + // TODO: We are cloning here for platforms but we dont need to do this for [BinaryView::type_container] // TODO: Why does this require that we, construct a TypeContainer, duplicate the type container, then drop the original. unsafe { TypeContainer::from_raw(type_container_ptr.unwrap()) } } -- cgit v1.3.1