From dc8a1ed20fb0a0a7341f940a4c224e2002928f4e Mon Sep 17 00:00:00 2001 From: Peter LaFosse Date: Thu, 28 Apr 2022 12:56:49 -0400 Subject: Improve navigation to correct tab when error/warn indicator is clicked Fix potential hang and new tab navigation when clicking error/warn indicator --- ui/logview.h | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) (limited to 'ui/logview.h') diff --git a/ui/logview.h b/ui/logview.h index 2c4d6057..c7e5af07 100644 --- a/ui/logview.h +++ b/ui/logview.h @@ -253,26 +253,22 @@ class BINARYNINJAUIAPI LogStatus : public QWidget QMenu* m_menu; std::mutex m_countMutex; - int m_totalErrorCount = 0; - int m_totalWarnCount = 0; std::map m_sessionErrorCount; std::map m_sessionWarnCount; size_t m_sessionId {0}; LogView* m_logView; - std::map getSessionToNameMap(); public: LogStatus(QWidget* parent); void setLogView(LogView* view) { m_logView = view; } void incrementErrorCount(uint64_t session, int count); void incrementWarningCount(uint64_t session, int count); - void clearIndicators(bool warnings, bool errors); void checkForErrors(); - void focusTab(QString tabName); - + void focusTab(UIContext* context, QWidget* tab); + void clearIndicators(); void updateTheme(); public Q_SLOTS: void notifySessionChanged(size_t sessionId); - private Q_SLOTS: - void clearStatus(bool error); + public Q_SLOTS: + void clicked(bool error); }; -- cgit v1.3.1