From cf4220570c2d1b7105fb29719383f64026d46837 Mon Sep 17 00:00:00 2001 From: Glenn Smith Date: Fri, 27 Jan 2023 18:53:27 -0500 Subject: Add virtual non-inline functions for interface classes This fixes a cases where trying to dynamic_cast to one of these interfaces fails for types defined in libraries, since the linker just copies the full definition into the library because it can, and then breaks the inheritance tree. --- ui/metadatachoicedialog.h | 2 ++ 1 file changed, 2 insertions(+) (limited to 'ui/metadatachoicedialog.h') diff --git a/ui/metadatachoicedialog.h b/ui/metadatachoicedialog.h index e2d07a14..64a2032e 100644 --- a/ui/metadatachoicedialog.h +++ b/ui/metadatachoicedialog.h @@ -29,6 +29,7 @@ struct EntryItem { */ class ManagedTableDelegate { public: + virtual ~ManagedTableDelegate(); // model virtual size_t ManagedTableColumnCount() = 0; virtual size_t ManagedTableRowCount() = 0; @@ -115,6 +116,7 @@ enum MetadataMode { class EntryItemMetadataViewDelegate { public: + virtual ~EntryItemMetadataViewDelegate(); virtual MetadataMode GetCurrentMode() = 0; virtual std::vector LinesForEntryItem(EntryItem& item) = 0; virtual QString PlaintextForEntryItem(EntryItem& item) = 0; -- cgit v1.3.1