From cf4220570c2d1b7105fb29719383f64026d46837 Mon Sep 17 00:00:00 2001 From: Glenn Smith Date: Fri, 27 Jan 2023 18:53:27 -0500 Subject: Add virtual non-inline functions for interface classes This fixes a cases where trying to dynamic_cast to one of these interfaces fails for types defined in libraries, since the linker just copies the full definition into the library because it can, and then breaks the inheritance tree. --- ui/uicontext.h | 2 ++ 1 file changed, 2 insertions(+) (limited to 'ui/uicontext.h') diff --git a/ui/uicontext.h b/ui/uicontext.h index 352a62dd..f68ea0a9 100644 --- a/ui/uicontext.h +++ b/ui/uicontext.h @@ -39,6 +39,8 @@ struct SelectionInfoForXref; class BINARYNINJAUIAPI UIContextNotification { public: + virtual ~UIContextNotification(); + /*! Callback after a UIContext is opened (eg MainWindow) \param context Opened context -- cgit v1.3.1