From bd1a1570722a9f4bf8d73c28f2410de7c293a00a Mon Sep 17 00:00:00 2001 From: Mark Rowe Date: Mon, 10 Nov 2025 21:13:50 -0800 Subject: [KernelCache] Remove 'Load Selected Image and Dependencies' Fixes https://github.com/Vector35/binaryninja-api/issues/7615. The dependency loading for kernel cache images was copied from the shared cache code, and looks for `LC_LOAD_DYLIB` load commands to determine the direct dependencies of an image. Images in kernel caches don't use `LC_LOAD_DYLIB` load commands so no dependencies were ever loaded. It could, however, result in a crash. --- view/kernelcache/ui/kctriage.cpp | 9 --------- 1 file changed, 9 deletions(-) (limited to 'view/kernelcache') diff --git a/view/kernelcache/ui/kctriage.cpp b/view/kernelcache/ui/kctriage.cpp index baae517c..6dd13067 100644 --- a/view/kernelcache/ui/kctriage.cpp +++ b/view/kernelcache/ui/kctriage.cpp @@ -208,7 +208,6 @@ QWidget* KCTriageView::initImageTable() QAction noSelectionAction("No Images Selected", m_imageTable); QAction loadImagesAction("", m_imageTable); - QAction loadImagesWithDepsAction("", m_imageTable); if (selectedCount == 0) { noSelectionAction.setEnabled(false); @@ -223,14 +222,6 @@ QWidget* KCTriageView::initImageTable() loadImagesWithAddr(addresses, false); }); contextMenu.addAction(&loadImagesAction); - - // Format action text for loading selected images with dependencies - QString loadWithDepsActionText = (selectedCount == 1) ? "Load Selected Image and Dependencies" : QString("Load %1 Selected Images and Dependencies").arg(selectedCount); - loadImagesWithDepsAction.setText(loadWithDepsActionText); - connect(&loadImagesWithDepsAction, &QAction::triggered, [this, addresses]() { - this->loadImagesWithAddr(addresses, true); - }); - contextMenu.addAction(&loadImagesWithDepsAction); } contextMenu.exec(m_imageTable->viewport()->mapToGlobal(pos)); -- cgit v1.3.1