From 2303f75b080f6dd0c9a5c669a71f64ce830f5650 Mon Sep 17 00:00:00 2001 From: Mark Rowe Date: Mon, 11 Aug 2025 10:42:07 -0700 Subject: Rewrite Obj-C workflow in Rust This is functionally equivalent to the previous workflow_objc, with the following changes: 1. It mutates the `core.function.metaAnalysis` workflow rather than registering a new named workflow. The activities now all check for the presence of the Objective-C metadata added by `ObjCProcessor` to determine whether they should do work, rather than relying on `MachoView` to override the function workflow when Objective-C metadata is present. This fixes https://github.com/Vector35/binaryninja-api/issues/6779. 2. The auto-inlining of `objc_msgSend` selector stub functions is performed in a separate activity from the processing of `objc_msgSend` call sites. The selector stub inlining activity is configured so that it does not run in `DSCView` as the shared cache needs different behavior for stub functions more generally that `SharedCacheWorkflow` already provides. 3. The way that types like `id` and `SEL` are referenced is fixed so that they show up as `id` rather than `objc_struct*`. This also replaces the Objective-C portion of the shared cache's workflow, and incorporates several bug fixes that had been applied to it but not the standalone Objective-C workflow. --- view/macho/machoview.cpp | 33 +++++++++++---------------------- 1 file changed, 11 insertions(+), 22 deletions(-) (limited to 'view/macho/machoview.cpp') diff --git a/view/macho/machoview.cpp b/view/macho/machoview.cpp index 1da2bda7..1c65629a 100644 --- a/view/macho/machoview.cpp +++ b/view/macho/machoview.cpp @@ -1845,6 +1845,17 @@ bool MachoView::InitializeHeader(MachOHeader& header, bool isMainHeader, uint64_ BinaryReader virtualReader(this); virtualReader.SetEndianness(m_endian); + if (m_file->IsBackedByDatabase(GetTypeName())) + { + // The `core.function.objectiveC` workflow has been removed in favor of the meta-analysis + // workflow. If the file is backed by a database, we need to update any references to the + // old workflow to refer to the meta-analysis workflow. + Ref analysisSettings = Settings::Instance(); + auto workflow = analysisSettings->Get("analysis.workflows.functionWorkflow", this); + if (workflow == "core.function.objectiveC") + analysisSettings->Set("analysis.workflows.functionWorkflow", "core.function.metaAnalysis", this); + } + bool parseObjCStructs = true; bool parseCFStrings = true; if (settings && settings->Contains("loader.macho.processObjectiveC")) @@ -1861,20 +1872,6 @@ bool MachoView::InitializeHeader(MachOHeader& header, bool isMainHeader, uint64_ { objcProcessor = std::make_unique(this); } - if (parseObjCStructs) - { - if (!settings) // Add our defaults - { - Ref programSettings = Settings::Instance(); - if (programSettings->Contains("corePlugins.workflows.objc")) - { - if (programSettings->Get("corePlugins.workflows.objc")) - { - programSettings->Set("analysis.workflows.functionWorkflow", "core.function.objectiveC", this); - } - } - } - } // parse thread starts section if available bool rebaseThreadStarts = false; @@ -4133,14 +4130,6 @@ Ref MachoViewType::GetLoadSettingsForData(BinaryView* data) "default" : true, "description" : "Processes Objective-C structures, applying method names and types from encoded metadata" })"); - Ref programSettings = Settings::Instance(); - if (programSettings->Contains("corePlugins.workflows.objc")) - { - if (programSettings->Get("corePlugins.workflows.objc")) - { - programSettings->Set("analysis.workflows.functionWorkflow", "core.function.objectiveC", viewRef); - } - } } if (viewRef->GetSectionByName("__cfstring")) { -- cgit v1.3.1