From 2e855275732aed00486ca100f4151f4074d9949e Mon Sep 17 00:00:00 2001 From: Mason Reed Date: Fri, 4 Apr 2025 23:45:06 -0400 Subject: [SharedCache] Add a named symbol map Fixes https://github.com/Vector35/binaryninja-api/issues/6561 - Also tightens the SharedCache class to move only, to prevent accidental copies. - Also removes some extra copies in FFI when should pass by ref - Also adds `get_symbol_with_name` to python API The current named symbol map is populated in a worker thread spawned in the view init. This is because populating the map can take about 1 second. If we are fine with another 1 second added to the view init time then we can add it serially but I don't think this way is _that_ bad, no analysis consults this, however a user might add a workflow that would be racing this. So we need to add a mutex. --- view/sharedcache/api/python/sharedcache.py | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'view/sharedcache/api/python/sharedcache.py') diff --git a/view/sharedcache/api/python/sharedcache.py b/view/sharedcache/api/python/sharedcache.py index e250b95b..dff9bcc3 100644 --- a/view/sharedcache/api/python/sharedcache.py +++ b/view/sharedcache/api/python/sharedcache.py @@ -214,6 +214,14 @@ class SharedCacheController: sccore.BNSharedCacheFreeSymbol(api_symbol) return symbol + def get_symbol_with_name(self, name: str) -> Optional[CacheSymbol]: + api_symbol = sccore.BNSharedCacheSymbol() + if not sccore.BNSharedCacheControllerGetSymbolWithName(self.handle, name, api_symbol): + return None + symbol = symbol_from_api(api_symbol) + sccore.BNSharedCacheFreeSymbol(api_symbol) + return symbol + @property def regions(self) -> [CacheRegion]: count = ctypes.c_ulonglong() -- cgit v1.3.1