From fa85bf28502286c4821427c5d0ed91a7ed46f8f6 Mon Sep 17 00:00:00 2001 From: Mason Reed Date: Fri, 7 Mar 2025 21:36:46 -0500 Subject: [SharedCache] Use DefineAutoUserSymbol instead of DefineAutoSymbol This makes it so that we persist the symbols within the regular symbol list in storage --- view/sharedcache/core/DSCView.cpp | 26 -------------------------- 1 file changed, 26 deletions(-) (limited to 'view/sharedcache/core/DSCView.cpp') diff --git a/view/sharedcache/core/DSCView.cpp b/view/sharedcache/core/DSCView.cpp index c8f49378..add2faff 100644 --- a/view/sharedcache/core/DSCView.cpp +++ b/view/sharedcache/core/DSCView.cpp @@ -614,32 +614,6 @@ bool DSCView::Init() Ref filesetEntryCommandType = Type::StructureType(filesetEntryCommandStruct); DefineType(filesetEntryCommandTypeId, filesetEntryCommandName, filesetEntryCommandType); - if (auto metadata = SharedCacheCore::SharedCacheMetadata::LoadFromView(this)) - { - BeginBulkModifySymbols(); - for (const auto& [imageBaseAddr, exportMap] : metadata->ExportInfos()) - { - auto typelib = GetTypeLibrary(metadata->InstallNameForImageBaseAddress(imageBaseAddr)); - - for (const auto& [address, symbol] : *exportMap) - { - if (!IsValidOffset(address)) - continue; - - if (typelib) - { - if (auto type = typelib->GetNamedObject(symbol->GetFullName())) - { - DefineAutoSymbolAndVariableOrFunction(GetDefaultPlatform(), symbol, type); - continue; - } - } - DefineAutoSymbol(symbol); - } - } - EndBulkModifySymbols(); - } - // uint32_t at 0x10 is offset to mapping table. // first mapping struct in that table is base of primary // first uint64_t in that struct is the base address of the primary -- cgit v1.3.1