From 8c3bd6e14eafe4b1d0af509c7abc7e6bd9a97c15 Mon Sep 17 00:00:00 2001 From: Mason Reed Date: Mon, 14 Apr 2025 17:17:42 -0400 Subject: [SharedCache] Evict file accessors from the global file accessor cache on file metadata destruction Previously we would just let them continue to exist after view destruction, this is fine assuming we expect the user to be re-opening the same cache over and over, but if a user wants to load a bunch of different caches they might want to evict the old file accessors so that COW pages are known to be evicted, along with other paged in memory. --- view/sharedcache/core/FileAccessorCache.cpp | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) (limited to 'view/sharedcache/core/FileAccessorCache.cpp') diff --git a/view/sharedcache/core/FileAccessorCache.cpp b/view/sharedcache/core/FileAccessorCache.cpp index 5fa965b3..28aab15d 100644 --- a/view/sharedcache/core/FileAccessorCache.cpp +++ b/view/sharedcache/core/FileAccessorCache.cpp @@ -68,6 +68,12 @@ WeakFileAccessor FileAccessorCache::Open(const std::string& filePath) return WeakFileAccessor(sharedAccessor, filePath); } +void FileAccessorCache::RemoveAccessor(const CacheAccessorID id) +{ + std::unique_lock lock(m_mutex); + m_accessors.erase(id); +} + std::shared_ptr WeakFileAccessor::lock() { auto sharedPtr = m_weakPtr.lock(); @@ -86,4 +92,4 @@ std::shared_ptr WeakFileAccessor::lock() } return sharedPtr; -} \ No newline at end of file +} -- cgit v1.3.1